search

lynxthecat / cake-autorate

Eliminate the excess latency and jitter terrorizing your 4G, 5G, LTE, Starlink or other variable rate connection!
https://www.bufferbloat.net
GNU General Public License v2.0
263 stars 24 forks source link

Fully commit on octave-first and octave-only for end statements #284

Closed moeller0 closed 4 months ago

moeller0 commented 4 months ago

Matlab only accepts a generic "end" while octave allows to document scope better by having distinct end variant like: if ... endif for ... endfor

While the code originally started under matlab, by now it is essentially octave only anyway so convert the last unadorned ends...

rany2 commented 4 months ago

I think I already made this change here: https://github.com/lynxthecat/cake-autorate/commit/68546ffb4cc03b6bbc0254c93cb6cfa42728d3d6 but I'll merge it anyway.

rany2 commented 4 months ago

Yep, the two commits are in fact identical. It's pretty strange how it shows up in the git history though :)

rany2 commented 4 months ago

@moeller0 I'm not sure if this interests you but it might prove helpful to you too: https://github.com/lynxthecat/cake-autorate/tree/d943630cc1ffb8e653d5b540c9ee21889c4e3d11/maint#octave-formatter-guide

It should be helpful if you ever wanted to go through your changes using git diff.

moeller0 commented 4 months ago

I will take a "pass" on this; nevertheless thanks.