lyoutakoduka / spartaproject

MIT License
0 stars 0 forks source link

Refactoring about variable and empty line #31

Closed lyoutakoduka closed 7 months ago

lyoutakoduka commented 8 months ago
  1. Unuse type "Any" of module "typing". https://github.com/lyoutakoduka/spartaproject/blob/94c95f1b25ddaae30c36181e3fdaedede8aefc7c/pyspartaproj/script/execute/call_module.py#L64

  2. Avoid duplication of variable name. https://github.com/lyoutakoduka/spartaproject/blob/94c95f1b25ddaae30c36181e3fdaedede8aefc7c/test/script/string/test_off_stdout.py#L15

  3. Avoid definition of variables in file module scope. https://github.com/lyoutakoduka/spartaproject/blob/94c95f1b25ddaae30c36181e3fdaedede8aefc7c/pyspartaproj/script/path/iterate_directory.py#L10

  4. Add appropriate line brake. https://github.com/lyoutakoduka/spartaproject/blob/94c95f1b25ddaae30c36181e3fdaedede8aefc7c/pyspartaproj/script/path/modify/avoid_duplication.py#L9

  5. Fix mismatch of data type. https://github.com/lyoutakoduka/spartaproject/blob/94c95f1b25ddaae30c36181e3fdaedede8aefc7c/test/script/file/config/test_export_config.py#L94

lyoutakoduka commented 7 months ago
  1. Use module to get path of current executed file instead of the built-in constant file path. https://github.com/lyoutakoduka/spartaproject/blob/94c95f1b25ddaae30c36181e3fdaedede8aefc7c/test/script/execute/test_call_module.py#L12