search

lyqyd / ComputerCraft-LyqydNet

A set of APIs and scripts for ComputerCraft to establish and operate an in-game computer network with routing.
22 stars 4 forks source link

Use of non-alphanumeric characters in a host name may fail #9

Closed davehayes closed 10 years ago

davehayes commented 10 years ago

In perusing /etc/hosts on a lyqyd net enabled router, I found that hosts labeled something like "foo-1.3" would simply say "foo" in the hosts file.

There's a pattern in netd.netDaemon which you use to get the host name: %w+. I believe you need to make this (and others) something like [%w%s-_] for greater portability between people's host naming paradigms.

I can provide a use case for this if you really need one. :)

lyqyd commented 10 years ago

This should be fixed in the develop branch, since as much string manipulation as possible has been done away with. I'll keep this issue open to remind me to review the file saving and reading functions to ensure that they also respect whatever the actual name of the computer is.

davehayes commented 10 years ago

Should new code be using your development branch?

lyqyd commented 10 years ago

Yes, it should be. I haven't had the time to do complete testing of all the changes to the code. The code that's in the develop branch currently will become the released version sooner or later, and there are breaking changes in it that will require all programs using LyqydNet APIs to update. I don't foresee any further need for breaking updates past that, at least once I have fully tested the new stuff. Bear in mind that using the new code means that programs written for the old stuff won't work until they're updated to use the new way of doing things.

If you start using it, please submit bug reports for any issues you run into with the newer stuff, as it will greatly aid the process. Thanks!