search

lyra / plugin-magento

An open source plugin that links Magento based e-commerce websites to PayZen secure payment gateway developed by Lyra Network.
https://lyra.com/fr/guides/magento/
Open Software License 3.0
10 stars 12 forks source link

Fix value for CURLOPT_SSL_VERIFYHOST #29

Closed sprankhub closed 1 year ago

sprankhub commented 1 year ago

Getting this error in production after updating to 2.6.1, which breaks the credit card input fields (they are not shown at all):

[2022-09-29T13:21:02.947211+00:00] lyra.ERROR: lyra 2.6.1 - Lyranetwork\Lyra\Model\Method\Standard::getRestApiFormToken : Notice: curl_setopt(): CURLOPT_SSL_VERIFYHOST no longer accepts the value 1, value 2 will be used instead in /var/www/share/client/releases/4/vendor/lyranetwork/module-lyra/Model/Api/Rest/Api.php on line 142 [IP = 127.0.0.1] [] []

From the docs of curl_setopt:

2 to verify that a Common Name field or a Subject Alternate Name field in the SSL peer certificate matches the provided hostname. 0 to not check the names. 1 should not be used. In production environments the value of this option should be kept at 2 (default value).

Support for value 1 removed in cURL 7.28.1.

sprankhub commented 1 year ago

Yeah, very cool, @nberhouche @GIMALima, this is really how open source works. Just copy the code, include it, pretend you developed it, do not thank / credit the original author. You really got how open source and collaboration works :pray: :+1:

nberhouche commented 1 year ago

There is a misunderstanding: the issue was first reported to us by a merchant on a support ticket. Your pull request came first but we didn't see until afterwards.

Thank your for your understanding.

sprankhub commented 1 year ago

Support ticket 145444? That was me, and I included a link to this PR.

If you do not monitor issues and PRs of your payment module, your process is broken and needs to be fixed.

Honestly, there is little understanding from my side.