search

lyrasis / aspace-islandora

Plugin to interoperate with Islandora.
3 stars 0 forks source link

Replace inline controller actions #7

Closed mark-cooper closed 7 years ago

mark-cooper commented 7 years ago

Right now there's a lot happening inline to make things work quick, however there are precedents for organizing things better:

Events

https://github.com/archivesspace/archivesspace/blob/master/backend/app/model/event.rb https://github.com/archivesspace/archivesspace/blob/master/backend/app/model/mixins/recordable_cataloging.rb#L14-L24

Agents

https://github.com/archivesspace/archivesspace/blob/master/backend/app/model/agent_software.rb https://github.com/archivesspace/archivesspace/blob/master/backend/app/model/agent_software.rb#L42

File Versions

Add class method to lookup whether exists already.

mark-cooper commented 7 years ago

https://github.com/lyrasis/aspace-islandora/pull/9