search

lyrgard / ffbeEquip

Online tool to filtre through FFBE Equipments
ISC License
83 stars 59 forks source link

contribution page: little things #363

Open tomurderthelight opened 5 years ago

tomurderthelight commented 5 years ago

"Premium" is missing from the "access" options. this means that if the access for Lohengrin, for example, is edited, there is no way to keep/reset the premium flag for it. the edit access window opens with nothing selected, and closing it without making changes removes all access.

Unreleased items: would it be possible to display these on the contributes page, so that access can be edited? behind a checkbox would be good, so they're not displayed by default. while i know it means having to look closer at the submissions, it would give people (like sinzar) another way to send you a heads up about newly released items, and possibly make it easier to add them.

tomurderthelight commented 5 years ago

also missing "recipe-chest"

theultramage commented 2 years ago

Currently, constants.js defines const accessList = ["shop","chest","quest","trial","chocobo","event","colosseum","key","TMR-1*","TMR-2*","TMR-3*","TMR-4*","TMR-5*", "STMR","recipe-shop","recipe-chest","recipe-quest","recipe-event","recipe-colosseum","recipe-key","trophy","recipe-trophy","premium","darkVision"]; Meanwhile, contribute.js has addTextChoicesTo("accessList",'checkbox',{ 'Shop':'shop', 'Recipe':'recipe', 'Chest':'chest', 'Chest Recipe':'recipe-chest', 'Quest':'quest', 'Key':'key', 'Chocobo':'chocobo', 'Event':'event', 'Event Recipe':'recipe-event', 'Trial':'trial', 'Trophy':'trophy', 'Colosseum':'colosseum', 'Premium':'premium', 'STMR':'STMR', 'TMR 5*':'TMR-5*', 'TMR 4*':'TMR-4*', 'TMR 3*':'TMR-3*', 'TMR 2*':'TMR-2*', 'TMR 1*':'TMR-1*', 'Not released yet':'not released yet'});

Here, the Contribute page seems to by trying to give each source a fancy text label. This turned out to be detrimental to code quality, as it creates a second, hardcoded copy of accessList, which has not been kept in sync and is now missing 5 entries. What's interesting is that the item description box renderer in the main sections of ffbeequip does not use these fancy labels either.