lyricwulf / Embers

Issue board for Embers. Issues only.
54 stars 6 forks source link

Pedal events are only held by the right-hand in free play mode #145

Closed MaddyGuthridge closed 4 years ago

MaddyGuthridge commented 4 years ago

Describe the bug When playing in free-play mode, pedals will only be sounded by the right-hand notes. I believe that this may be due to the way that these events are split into the two tracks - pedals won't be duplicated across to the second.

To Reproduce Steps to reproduce the behavior:

  1. Open Embers in Free Play Mode, using a keyboard with a pedal attached.
  2. With the pedal held down, play staccato notes in both the upper and lower registers.
  3. Notice that only notes in the right hand are held as pedals.

Expected behavior The pedal events will be duplicated between each track.

Desktop (please complete the following information):

Additional context You may want to consider duplicating all CC events (modulation, program change, etc) Note that the event for a pedal is (status: 0xB0, data1 = 0x40, data2 = 0 or 0x7F)