lyricwulf / Embers

Issue board for Embers. Issues only.
54 stars 6 forks source link

Problems with the style menu (Sustain pedal and delay) #146

Closed Ian-Voss closed 3 years ago

Ian-Voss commented 4 years ago

Describe the bug: While editing styles, a previously used midi will play. when this midi is playing, the sustain pedal is held all throught, greatly distorting the sound. After a while the visuals in the notes that fall and the keys desync.

To reproduce: .select a midi and play it .Go to the styles menu .Listen to the midi .The delay effect I only saw once after editing for a long while

Expected behaviour: My midi doesn't use the sustain pedal anywhere and I don't have a keyboard connected, There shouldn't be any sustain.

Video: https://drive.google.com/file/d/16m8r0pPr_8Fterr4SJt14etTw4ZCenh6/view?usp=sharing

Desktop: CPU: AMD Ryzen 3 2200 G with VEGA 3.50 Ghz GPU: Nvidia 1650 OS: Windows 10 latest Embers version: 2.0

Ian-Voss commented 4 years ago

If you slow down the linked video you can see that there's a little bit of delay.