lyricwulf / Embers

Issue board for Embers. Issues only.
54 stars 6 forks source link

Unique notes causing increased base GPU usage #88

Closed Naturalizze closed 4 years ago

Naturalizze commented 4 years ago

Describe the bug in midi playback/input level, the GPU will not unuse any resource it's taken. Meaning, if it needs X percent for something, then that something goes away, it only seems to give back Y percent. Y being a seemingly random amount that's less than X.

this usage might be tied to a framerate issue ( #56 ), as I've noticed that framerate/midi tempo go down later on throughout midis, even if they're not complicated.

To Reproduce Steps to reproduce the behavior:

  1. Play a midi/go to midi input mode
  2. watch the midi and monitor gpu usage/monitor usage before you play a single key on input mode
  3. monitoring GPU usage throughout the song, notice that the end of the song is still using a ton of GPU, even if only 2 things on screen and nothing new coming/slam on the keyboard to generate particles and notes, and notice that after the GPU is hit, it doesn't go back to the same idle usage it was before

Expected behavior The GPU should be letting go of resources as they're no longer needed properly/framerates to be stable throughout a song

Screenshots https://i.gyazo.com/42d6b623ef60947508ed1463a8cb8a80.mp4 beginning of song

https://i.gyazo.com/8ad1f66a1bf24088194acbb7370d96be.mp4 end of song

https://i.gyazo.com/2514a05e60169a2bae72ee463150caa3.mp4 at the beginning, notice my idle usage, then my idle usage after slamming on the keyboard.

Desktop (please complete the following information):

Additional context This seems to happen with others as well. it's mentioned in the linked ticket, as well as this screenshot of theirs. check their idle GPU usage on their 1070 at the beginning and after they played enough notes to reach 100% GPU usage and framerate.

Naturalizze commented 4 years ago

Determined this is due to unique notes being hit. see comparison video showing what i mean:

https://drive.google.com/open?id=1_2xsL3pXeqrCmwJGpviHKgmQuUhArc1p