search

lyrixx / SFLive-Paris2016-Workflow

Demo app for the new symfony/workflow component
https://s.lyrixx.info/workflow-demo
176 stars 41 forks source link

Change transitions to verbs #14

Closed tacman closed 6 years ago

tacman commented 6 years ago

I think the transition names should be verbs. In particular, in the task workflow 'done' is a state, but 'finish' is a verb that would make sense for the transition. Plus, having a transition and a state as the same word is possible, but might be confusing.

Similarly, I think 'process' is a better term to use than 'processing', which sounds like a state.

Happy to make those changes and submit a PR.

lyrixx commented 6 years ago

You are totally right.

I will be glad to merge your PR.

(Note: I'm not a native English speaker. I'm pretty sure you had already notice that. That's why my wording is not perfect)

tacman commented 6 years ago

I expanded the task workflow and changed the terminology a bit:

image

I've been thinking about a Symfony 4 demo project that is a web crawler, and the idea is that when crawling links they might temporarily fail (server busy, etc.) or permanently fail (no route to domain, etc.), and this workflow reflects that.