lyspring / adwhirl

Automatically exported from code.google.com/p/adwhirl
0 stars 0 forks source link

House Ads Not Confined to 320x52 #112

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
http://groups.google.com/group/adwhirl-users/browse_thread/thread/7b299d6131c8b5
65/4435393bd1c08bd4?#4435393bd1c08bd4

Original issue reported on code.google.com by jpin...@google.com on 29 Sep 2010 at 11:14

GoogleCodeExporter commented 8 years ago

Original comment by jpin...@google.com on 12 Oct 2010 at 10:23

GoogleCodeExporter commented 8 years ago
Fixed, will be in release of v2.5.5.

Original comment by jpin...@google.com on 12 Oct 2010 at 11:32

GoogleCodeExporter commented 8 years ago
Using 2.5.5

I calculate the size of the view properly, taking into account the 
metrics.density.

Testing with a Droid:
The House ad shows centered in the view, looks like not resized at all to fill 
the view. Admob ads show resized properly to fill the view.

Testing with a G1 and a Tattoo: Works as expected.

Original comment by DiegoMor...@gmail.com on 1 Nov 2010 at 6:32

GoogleCodeExporter commented 8 years ago
Will take another look.

Original comment by jpin...@google.com on 1 Nov 2010 at 3:31

GoogleCodeExporter commented 8 years ago

Original comment by jpin...@google.com on 4 Nov 2010 at 12:06

GoogleCodeExporter commented 8 years ago

Original comment by fch...@google.com on 16 Nov 2010 at 10:24

GoogleCodeExporter commented 8 years ago
Have the same on a Nexus running non standard resolution.
Ads from admob and millenial and text houseads are resized correctly but the 
banner house ads wil just show small and centered inside the banner part.

Original comment by michel.racic on 23 Nov 2010 at 12:08

GoogleCodeExporter commented 8 years ago
The fix is targeted for an upcoming release.

Original comment by fch...@google.com on 23 Nov 2010 at 12:52

GoogleCodeExporter commented 8 years ago

Original comment by jpin...@google.com on 24 Nov 2010 at 9:48

GoogleCodeExporter commented 8 years ago
Noticed a related issue. Ads from admob size correctly, house ads appear to 
fill the parent from the anchor point. For example, using 
<android:layout_below="xxx"> a house ad will fill to the bottom (of the 
container?); using <android:layout_above="xxx"> will fill to the top(of the 
container?).

Setting a fixed size works for my purposes at the moment so I haven't played 
with the container layouts, but it appears the outer boundary for house ads is 
defined by [anchor.x,anchor.y]->[parent.opposite.x,parent.opposite.y].

Original comment by goo...@yourarcade.com on 15 Jan 2011 at 10:37

GoogleCodeExporter commented 8 years ago
I am unsing 2.6.2  AdWhirl SDK and in house banner ads doen't work, I can see 
the banner center in the ad layout but it doesn't fill the width.

If I use admob ad all work fine.

See the image attached!

Original comment by pulsarpi...@gmail.com on 16 Feb 2011 at 11:56

Attachments:

GoogleCodeExporter commented 8 years ago
It's not working. Can you reopen the issue please.
I have:
<TabHost xmlns:android="http://schemas.android.com/apk/res/android"
    android:id="@android:id/tabhost"
    android:layout_width="fill_parent"
    android:layout_height="fill_parent">
    <LinearLayout
        android:orientation="vertical"
        android:layout_width="fill_parent"
        android:layout_height="fill_parent"
        >

        <com.adwhirl.AdWhirlLayout
        android:id="@+id/ad"
            android:layout_width="fill_parent"
            android:layout_height="wrap_content"
        />

And the admob and millennial ads works well, but house ads take all the space.

It's possible also to upload the priority, because it makes not usable hous ads.

Original comment by joanpu...@gmail.com on 15 Mar 2011 at 9:59

Attachments:

GoogleCodeExporter commented 8 years ago
[deleted comment]
GoogleCodeExporter commented 8 years ago
[deleted comment]
GoogleCodeExporter commented 8 years ago

Please reopen this issue, it's not fixed in v3.0.0.

I tested it with G1 (mdpi) or Tattoo (ldpi) -> no problem.

With Motorola Droid/Milestone and HTC Desire (both hdpi) -> The house add 
doesn't fill the expected space (320x50).

I agree with previous poster, right now On 51.2%+ of phones (hdpi) house adds 
are not usable. This deserves a higher priority.

It should be a hopefully quick change in:

http://code.google.com/p/adwhirl/source/browse/src/com/adwhirl/adapters/CustomAd
apter.java?repo=sdk-android

In case AdWhirlUtil.CUSTOM_TYPE_BANNER: LayoutParams.WRAP_CONTENT is wrong as 
it is, it probably needs to be done in the same way as case 
AdWhirlUtil.CUSTOM_TYPE_ICON.

Thanks

Original comment by DiegoMor...@gmail.com on 25 Apr 2011 at 6:03

GoogleCodeExporter commented 8 years ago
I'm also having the same problem! Tested on two different hdpi devices!

Original comment by thiago.r...@gmail.com on 21 Sep 2011 at 2:45