lythx / trakman

Trackmania Forever server controller written in TypeScript
https://trakman.ptrk.eu
MIT License
24 stars 4 forks source link

Question / The philosophy of counting stats (TopSums, TopRecords and TopVotes) #246

Closed xadll closed 5 months ago

xadll commented 7 months ago

I think XAseco calculated stats from all maps including those from the past, the same way Trakman do, but that always seemed odd to me. Is there something important behind it that I'm missing?

Should these stats also be calculated from maps that have been played in the past but are no longer physically in the maplist? I like the opposite idea - show statistics calculated from the current maplist only. What is your opinion?

Stats of top 3 players when currently only 2 maps are on maplist

20240121_175429-131 20240121_175424-976 20240121_175310-063

wsrvn commented 7 months ago

this is a bug in our code, stats should only be calculated using the current maplist

we meant to fix this for 1.4.3, but thought delaying the pr merge was not that great

wsrvn commented 6 months ago

should be fixed via 67ed889