search

lythx / trakman

Trackmania Forever server controller written in TypeScript
https://trakman.ptrk.eu
MIT License
24 stars 4 forks source link

Re-queuing doesn't work properly #254

Open felacek opened 6 months ago

felacek commented 6 months ago

Upon requeuing a map, it gets put at the back of the jukebox (at least on FTU, which I believe is running dev).

When requeuing multiple times, it only appears once, but is actually there multiple times, which is confusing.

The solution is either to disallow juking the same map multiple times (really not ideal!!), or to display the queued maps in the correct order.

wsrvn commented 6 months ago

Upon requeuing a map, it gets put at the back of the jukebox (at least on FTU, which I believe is running dev).

this cannot possibly be true because i tested it prior to 80acc84 and it seemed to work just fine after 30c1492 (//rq puts the map as index 0 in the q)

When requeuing multiple times, it only appears once, but is actually there multiple times, which is confusing.

regression introduced in 80acc84

The solution is either to disallow juking the same map multiple times (really not ideal!!), or to display the queued maps in the correct order.

maplist issue @lythx

felacek commented 6 months ago

this cannot possibly be true

I tested it after 80acc84 and it didn't work. Seems that commit broke it.