search

lytics / hll

HyperLogLog++ for Go
Apache License 2.0
43 stars 6 forks source link

Why does Gob encoder proxy to JSON #10

Open harlow opened 7 years ago

harlow commented 7 years ago

this was a little surprising: https://github.com/lytics/hll/blob/master/hll.go#L319-L322

Any reason for not using Gob?

timkaye11 commented 7 years ago

Good question. I don't think there is a good reason for not using Gob (I think I was just being lazy when I wrote it). I'll work on correctly implementing GobEncode() and GobDecode()

harlow commented 7 years ago

Happy to submit a PR. Just wanted to check if there was a reason before doing so

On Tue, Jul 18, 2017 at 6:21 PM Tim Kaye notifications@github.com wrote:

Good question. I don't think there is a good reason for not using Gob (I think I was just being lazy when I wrote it). I'll work on correctly implementing GobEncode() and GobDecode()

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/lytics/hll/issues/10#issuecomment-316244616, or mute the thread https://github.com/notifications/unsubscribe-auth/AAtJxrK-oo58BHhTxM7ggwN7rEAAXOSnks5sPVn9gaJpZM4Ob2hf .

-- Harlow Ward harlow@hward.com 805-450-5522