search

lytics / hll

HyperLogLog++ for Go
Apache License 2.0
43 stars 6 forks source link

Bigquery compatibility #13

Open erikdubbelboer opened 4 years ago

erikdubbelboer commented 4 years ago

Thanks for this library. I have made some big changes on my fork to make it compatible with BigQuery HLL functions. Which kinda makes it compatible with Google's zetasketch.

You can see the changes here: https://github.com/lytics/hll/compare/master...erikdubbelboer:master

The changes are major and change things like the way the hashes are encoded. This obviously breaks backwards compatibility for the Gob and JSON encodings.

I was wondering if you had any interest in merging this or if I should just continue maintaining my changes on my fork?

timkaye11 commented 4 years ago

hi @erikdubbelboer - thanks for using this library!

As we currently use this library in production, and since your changes break backwards compatibility, I think we might want to keep your fork separate from master.