search

lytics / pathforajs

Web personalization SDK
https://www.lytics.com/
MIT License
2 stars 0 forks source link

bug: hotfix position validation for modals. #553

Closed ashyablok closed 3 years ago

ashyablok commented 3 years ago

closes #554 Looks like the UI sets the middle-center position for modals. :facepalm:

codecov[bot] commented 3 years ago

Codecov Report

Merging #553 (9d33727) into develop (c9540e5) will decrease coverage by 0.09%. The diff coverage is 66.66%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #553      +/-   ##
===========================================
- Coverage    90.88%   90.79%   -0.10%     
===========================================
  Files          118      118              
  Lines         2215     2215              
  Branches       661      661              
===========================================
- Hits          2013     2011       -2     
- Misses         202      204       +2
Impacted Files Coverage Δ
src/rollup/validation/validate-widget-position.js 84.21% <66.66%> (ø)
src/rollup/widgets/show-widget.js 75.75% <0.00%> (-3.04%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c9540e5...9d33727. Read the comment docs.

humanchimp commented 3 years ago

can we change the throw to console.warn?