search

lytics / pathforajs

Web personalization SDK
https://www.lytics.com/
MIT License
2 stars 0 forks source link

Issue/617 sitegate form elements #618

Closed humanchimp closed 2 years ago

humanchimp commented 2 years ago

Closes #617

When using the sitegate layout form elements may not be present, in which case, we should not try to assign an aria-label attribute, since attempting to do so will result in a TypeError.

codecov[bot] commented 2 years ago

Codecov Report

Merging #618 (b6f5850) into develop (9bb12ae) will increase coverage by 0.31%. The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #618      +/-   ##
===========================================
+ Coverage    90.80%   91.11%   +0.31%     
===========================================
  Files          118      118              
  Lines         2261     2263       +2     
  Branches       677      678       +1     
===========================================
+ Hits          2053     2062       +9     
+ Misses         208      201       -7
Impacted Files Coverage Δ
src/rollup/widgets/construct-widget-layout.js 90.27% <100.00%> (+3.93%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9bb12ae...b6f5850. Read the comment docs.