search

lyueyang / pe

0 stars 0 forks source link

Duplicate items error not shown to user when loading #12

Open lyueyang opened 3 years ago

lyueyang commented 3 years ago

When providing 2 identical trackpants Screenshot 2021-04-16 at 3.04.39 PM.png

Screenshot 2021-04-16 at 3.05.02 PM.png

If a user has an identical piece of clothing, nufash fails without warning

nus-pe-bot commented 3 years ago

Team's Response

Only advanced users are to edit the json file. This is listed in the UG alongside warnings.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: In this case, there was no response provided by NuFash to determine what the issue is, thereby creating inconvenience for the user. In the event whereby multiple entries were keyed wrongly or if the file was huge, it would create inconvenience for the user to locate the invalid entry.

The warning provided in the UG is as follows: Screenshot 2021-04-20 at 12.28.20 PM.png

Suppose if multiple errors were made when editing the json file, it would create inconvenience for the user to have to manually check where the errors were located.