search

lyueyang / pe

0 stars 0 forks source link

Duplicate name item with different case isn't caught #2

Open lyueyang opened 3 years ago

lyueyang commented 3 years ago

If users were not careful with the naming of the product ie

Screenshot 2021-04-16 at 2.31.34 PM.png

Where pants was changed to "t shirt", this might pose some inconvenience to the user. While the edit and add command was able to catch when the exact same case was used, it could not catch when a different case was used by the user.

Screenshot 2021-04-16 at 2.33.29 PM.png

nus-pe-bot commented 3 years ago

Team's Response

No response provided.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Case sensitivity of add and edit command not documented

There was no mention of the name of the item being case sensitive which results in bad behavior where duplicate items of the same name with different cases can be added.

In Add Command: Screenshot 2021-04-16 at 2.34.04 PM.png

In Edit Command: Screenshot 2021-04-16 at 2.34.45 PM.png

[original: nus-cs2103-AY2021S2/pe-interim#1582] [original labels: severity.Medium type.DocumentationBug]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

This was considered during the design. Since we do not allow exact duplicates of the same item for ease of organisation, this along with enumeration is one of the ways in which people may choose to differentiate their clothes. Since it does not throw an error, and was an intentional decision, it was not documented.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: Instead of a DocumentationBug, perhaps I would suggest this being a feature flaw instead. The team has suggested that the difference in cases were such as to allow its users to differentiate between the different articles of clothing. i.e. School shirt and SCHOOL SHIRT are to be considered different articles of clothing.

Such a suggestion just creates more inconvenience for users as they have to remember which shirt correlates to which. This claim also goes against the idea of being able to have more ways for the user to identify different shirts when shirts with the same name and case but different colour i.e. camp shirt (colour: green) and Camp Shirt (colour: red). is not allowed.

Considering that users are likely to have multiple articles of clothing with the same name, I believe that it should be a Medium severity as this is a common situation.

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: Same as per duplicate status response.

:question: Issue type

Team chose [type.DocumentationBug] Originally [type.FunctionalityBug]

Reason for disagreement: Same as per duplicate status response.