In slurm, the values of long options should be introduced by an equal sign

gqqnbig commented 1 year ago

Spaces may be used, but they are not compliant.

gqqnbig commented 1 year ago

For #142, we should always use the equal sign because the slurm documentation uses it.

gqqnbig commented 1 year ago

Reviewer, please study why the CI is fail, fail, pass. Notice in the interm, I made this fix to the wiki.

gqqnbig commented 1 year ago

Code Review Checklist

[ ] Code style: does the code conform the company code style?
[ ] Bugs: does the code have bugs, fail in corner cases? Did you personally run the code?
[ ] CI step/test: does existing CI step or test cover the piece of code changed in this PR? Should a new CI step or test be added?
[ ] Support requests: does this change incur new support request? does this change follow good patterns in human-computer interface?
[ ] Installation: how to install this feature? Does this feature alter existing installation step/script?
[ ] Documentations: Is the change reflected on the wiki or on the repo? Does this program support --help option?