Mofidy slurm.conf to add hoth

lyulyul / shine-cluster

Simple High performance Infrastructure for Neural network Experiments

GNU General Public License v3.0

14 stars 8 forks source link

Mofidy slurm.conf to add hoth #152

Closed luoyuqi-lab closed 1 year ago

luoyuqi-lab commented 1 year ago

For #122 Modify slurm.conf.

gqqnbig commented 1 year ago

Code Review Checklist

[x] Code style: does the code conform the company code style?
[x] Bugs: does the code have bugs, fail in corner cases? Did you personally run the code?
[x] CI step/test: does existing CI step or test cover the piece of code changed in this PR? Should a new CI step or test be added?
[x] Support requests: does this change incur new support request? does this change follow good patterns in human-computer interface?
[x] Installation: how to install this feature? Does this feature alter existing installation step/script?
[ ] Documentations: Is the change reflected on the wiki or on the repo? Does this program support --help option?

gqqnbig commented 1 year ago

Code style: does the code conform the company code style?

NodeName= should be in alphabetical order. But let you pass this time.

Is the change reflected on the wiki or on the repo?

既然hoth将要加到集群了，wiki里有什么要改的吗？hoth有什么特色值得用户注意吗？

注：我不是指如何安装服务器。安装服务器的技巧你自己加进wiki里，或许是面向管理员的页面。

注：你可以搜hoth或者现有节点的名称，看看wiki是怎么描述它们的。

luoyuqi-lab commented 1 year ago

Code style: does the code conform the company code style?

NodeName= should be in alphabetical order. But let you pass this time.

Is the change reflected on the wiki or on the repo?

既然hoth将要加到集群了，wiki里有什么要改的吗？hoth有什么特色值得用户注意吗？

注：我不是指如何安装服务器。安装服务器的技巧你自己加进wiki里，或许是面向管理员的页面。

注：你可以搜hoth或者现有节点的名称，看看wiki是怎么描述它们的。

搜索后似乎只有在集群简介里面提到了hoth，并且那个简介有点老了需要更新。

别的关于anaconda和软件之类的，hoth似乎也没装好，不过应该不算在这个issue里。