lyuma / Av3Emulator

Emulator for VRChat's Avatars 3.0 system, built on the Unity PlayableGraph API
Other
538 stars 32 forks source link

defer initialize Av3Emulator to Start #125

Closed anatawa12 closed 8 months ago

anatawa12 commented 1 year ago

Initializing Av3Emulator in Awake will cause incompatibility with tools applied on IProcessSceneWithReport.

Awake is very very early state in scene initialization which can (not always) be before IProcessSceneWithReport, a unity official way to modify scene before game execution. Is there any reason OnSceneLoad Start is too late?

anatawa12 commented 1 year ago

In addition, Calling IVRCSDKPreprocessAvatarCallback in Awake can cause editor crash. https://github.com/VRCFury/VRCFury/pull/77#issuecomment-1669127198

anatawa12 commented 1 year ago

I also removed OnSceneLoad because Scene Reload on entering Play mode can be disabled.

jellejurre commented 8 months ago

Superseded by #144