search

lyusupov / SoftRF

:airplane: Multi-functional, compatible DIY general aviation proximity awareness system
GNU General Public License v3.0
756 stars 211 forks source link

bug fix for gdl90_escape_message_for_tx() #136

Closed aaknitt closed 1 year ago

aaknitt commented 1 year ago

bug fix for incorrect escaping that results in an invalid message and bad CRC. Original code assumes that first flag byte and message ID byte are inside the data[] array within the rawMsg->data[] array but they are actually separate fields within the gdl_message_t struct.

lyusupov commented 1 year ago

1) We may consider to process this patch when the sub-component Rotobox library will accept it ; 2) this PR has likely no effect for the SoftRF project since it mostly uses own GDL90 encoder . Rotobox decoder is in use for SkyView purpose only. AFAIR, the Rotobox encoder (e.g. _gdl90_escape_message_fortx) is not in use at all.

Resolution: deferred