lyusupov / SoftRF

:airplane: Multi-functional, compatible DIY general aviation proximity awareness system
GNU General Public License v3.0
784 stars 216 forks source link

Suggested updates. #70

Closed nbonniere closed 5 years ago

nbonniere commented 5 years ago

All other data is based on 'this_aircraft' data and time should be as well.

lyusupov commented 5 years ago

Both commits generally looks Ok to me. It will take roughly few days to evaluate these proposed changes on my local OGN receiver, with both 'Region' settings. As long as it does not break 'EU mode' - I basically don't care.

I am curious, why are you proposing to switch onto Pawel's new NA freq. hopping plan while, I suppose, most of (few) N/S. America and Australia OGN receivers are still running 'old' binary code of the hopping algorithm? Is the 'new' algorithm compatible with 'old' one?

nbonniere commented 5 years ago

Pawel's new OGN code only changes frequency slot 2. Slot 1 is unaffected. The OGN receiver doesn't hop to slot 2, so he made a change to the OGN frequency plan so that slot 2 of OGN falls within the bandwidth of the OGN receiver, so he can receive the second packet and thus improves the probability of receiving one or the other or both.

lyusupov commented 5 years ago

Any other patches except related to the OGN topic will block or CANCEL processing of this PR entirely. Reasons were explained there: https://github.com/lyusupov/SoftRF/issues/58

nbonniere commented 5 years ago

For testing, I am using Pawel's v0.2.7 OGN receiver code, not v0.2.6.

lyusupov commented 5 years ago

Re-file