search

lyuts / vim-rtags

Vim bindings for rtags, llvm/clang based c++ code indexer.
BSD 2-Clause "Simplified" License
282 stars 56 forks source link

+python is not needed #37

Closed jmacdonagh closed 8 years ago

jmacdonagh commented 8 years ago

Since 754ad203e4f993850d2772155f6e38398def86b0, it does not appear that +python is needed. In the current master, the only function that needs it is Offset2LineCol, and that function isn't called anymore since rc changed their output format (as fixed in 754ad203e4f993850d2772155f6e38398def86b0).

Requiring this isn't too big of a deal, except that Ubuntu 16.04's vim seems to only have +python3.

lyuts commented 8 years ago

That's right, good find. Cleaned that up. Thank you.

jmacdonagh commented 8 years ago

Thanks! You'll need to remove this condition too:

https://github.com/lyuts/vim-rtags/blob/master/plugin/rtags.vim#L2

jmacdonagh commented 8 years ago

@lyuts, can you remove the check I mentioned above? It's not needed and will break newer python3 vim builds. Thanks!

lyuts commented 8 years ago

Ah, missed that. It is now gone (a2686008795a9ab4822cd6f4a7013fbdffad639a).