search

lyuts / vim-rtags

Vim bindings for rtags, llvm/clang based c++ code indexer.
BSD 2-Clause "Simplified" License
282 stars 56 forks source link

Add commads 'FindSuperClasses' and 'FindSubClasses' #43

Closed dan-t closed 8 years ago

lyuts commented 8 years ago

Thank you for this change. If you don't mind, could you add tests for FindSubClasses and FindSuperClasses functions? Those would be helpful if the output format from rc changes.

dan-t commented 8 years ago

On Sun, Jun 26, 2016 at 05:12:16PM -0700, lyuts wrote:

Thank you for this change. If you don't mind, could you add tests for FindSubClasses and FindSuperClasses functions?

Ok, I will take a look.

dan-t commented 8 years ago

On Sun, Jun 26, 2016 at 05:12:16PM -0700, lyuts wrote:

Thank you for this change. If you don't mind, could you add tests for FindSubClasses and FindSuperClasses functions? Those would be helpful if the output format from rc changes.

Looking at the current tests, none of it uses 'rc', but just creates artificial output of 'rc' and checks if the plugin code handles it correctly.

To really test if the 'rc' output changes, there has to be c++ test project, which gets indexed by 'rc' and then check the output of 'rc' for this project.

I've now just added unittests with artificial data.

lyuts commented 8 years ago

Yes, that's correct. There is no real invocation of rc in tests, but that's the best we have at this point. Thank you for adding tests.