search

lyuts / vim-rtags

Vim bindings for rtags, llvm/clang based c++ code indexer.
BSD 2-Clause "Simplified" License
282 stars 56 forks source link

[RFC] Implement rtags#Diagnostics - display warnings and errors #52

Closed marxin closed 7 years ago

marxin commented 7 years ago

Hello.

I would like to help you with the project and rtags can display errors/warnings for a current file. I prepared a patch which is a just a draft. I would like to ask whether using python3 is possible? This is my first VIM plug-in and so that I decided to parse the XML result in python.

marxin commented 7 years ago

screenshot from 2016-11-14 11-32-14

marxin commented 7 years ago

It's attempt to address #44

lyuts commented 7 years ago

Thanks a lot for helping with this. Looks good. How hard is it to make this change work with both python 2 and python3? Ideally I'd like all types of environments to be able to use this plugin. I think most of personal setups should be fine with python 3, but I came across some environments (like at work, where people have to use company provided distros) which are slightly outdated and which don't have python 3 installed at all. I'd say this is not blocking this change for now, just wish we have this case covered.

marxin commented 7 years ago

Hi! I'm happy that you welcome the changes, I have another items on my TODO list which can be done related to rtags#Diagnostics: 1) python2 - as you mentioned 2) it does not properly work with an unsaved content 3) as YCM does, we may want to periodically trigger the rebuild; hope an option would be feasible for that 4) define symbols for error, warning, fixit

I'm planning to return to this during Christmas time.

lyuts commented 7 years ago

Sounds good. Thanks again for the contribution.