search

lyz-code / autoimport

Autoimport automatically fixes wrong import statements.
https://lyz-code.github.io/autoimport
GNU General Public License v3.0
95 stars 23 forks source link

Deleted dependency detected #254

Open ashishbijlani opened 8 months ago

ashishbijlani commented 8 months ago

I'm a Cyber Security researcher and developer of PackjGuard [1] to address open-source software supply chain attacks.

Issue

During my research, I found that this repo is vulnerable to attack due to deleted dependency from the public PyPI registry.

Details

Specifically, file https://github.com/lyz-code/autoimport/blob/b421368d64027a0d253ae247da8ce08659f5277c/pyproject.toml lists projroot as one of the dependencies. However, it has been deleted from public PyPI. As such, an external bad actor can claim that name and register a malicious package, which will be then installed with pip install command, resulting in arbitrary remote code execution.

Impact

Not only your apps/services using https://github.com/lyz-code/autoimport repo code are vulnerable to this attack, but the users of your open-source Github repo could also fall victim.

You could read more about such attacks here: https://medium.com/@alex.birsan/dependency-confusion-4a5d60fec610

Remediation

Please manually register a placeholder projroot package on PyPI immediately or remove projroot dependency from https://github.com/lyz-code/autoimport/blob/b421368d64027a0d253ae247da8ce08659f5277c/pyproject.toml to fix this vulnerability.

To automatically fix such issues in future, please install PackjGuard Github app [1].

Thanks!

  1. PackjGuard is a Github app that monitors your repos 24x7, detects vulnerable/malicious/risky open-source dependencies, and creates pull requests for auto remediation: https://github.com/marketplace/packjguard
lyz-code commented 7 months ago

Thank you @ashishbijlani for the notice <3.

Right now I'm not maintaining the project but if you want to make a PR to fix the code I'll gladly review it