lyz-code / autoimport

Autoimport automatically fixes wrong import statements.
https://lyz-code.github.io/autoimport
GNU General Public License v3.0
96 stars 24 forks source link

allow disabling move to top functionality #257

Closed wbbradley closed 2 months ago

wbbradley commented 2 months ago

Hello, thanks for the great work with autoimport! This PR implements a bit of functionality I've been missing in autoimport, which is to allow users (through configuration) to disable the "move to top" feature.

Rationale

I am working in an large codebase that has several areas of circular dependencies, and at this stage, it is not a priority to detangle that mess. I understand and appreciate the value of "code as a DAG", however in this instance I'd still like to be able to leverage the other functionality in autoimport without having to prioritize cycle breaking in my project.

This issue has been raised here.

Checklist

lyz-code commented 2 months ago

Hi @wbbradley thanks for the PR.

I don't either have time right now to fix the issue sorry :(, you will probably be able to solve the issue by running make update

lyz-code commented 2 months ago

Alternatively you can disable the check in the CI if you want as I feel it's more important the easiness in contribution than the security

coveralls commented 2 months ago

Pull Request Test Coverage Report for Build 9886215236

Details


Totals Coverage Status
Change from base Build 9029820318: 0.09%
Covered Lines: 320
Relevant Lines: 334

💛 - Coveralls
wbbradley commented 2 months ago

I've gone ahead and bumped the versions of mkdocs and commitizen, and I've ignored the specific vulnerability found in the prior run but left all other checks running. Thanks for your help, and again, thanks for autoimport. Let me know if there are other steps I can take care of to help get it pushed up to pypi. And, I'm totally open to feedback on anything I did here. Mostly just tried to get my use-case unblocked.