-1 issue if using read method

[sorenop]

I ran into an issue with the LZ4FrameInputStream.read() method: When the resulting one byte is '-1' (0xFF) this is not properly converted to unsigned int and is thus mistaken for the 'error return value' I guess that in most situations you would not use the read() method, but anyway ... Issue was found in 1.4.0 but is also present in 1.5

This test fails:

public void testLZ4LibFFFlaw() throws Exception {
        byte[] source = new byte[1];
        source[0] = (byte) 0xFF;
        byte[] dest = new byte[1];

        ByteArrayOutputStream bos = new ByteArrayOutputStream();
        LZ4FrameOutputStream compressedStream = new LZ4FrameOutputStream(bos);
        compressedStream.write(source);
        compressedStream.close();

        ByteArrayInputStream bis = new ByteArrayInputStream(bos.toByteArray());
        LZ4FrameInputStream decompressedStream = new LZ4FrameInputStream(bis);
        int i = 0;
        int data;
        while (i == 0) {
            data = decompressedStream.read();
            if (data == -1) {
                break;
            }
            dest[i++] = (byte) data;
        }
        assertEquals(source[0], dest[0]);
    }

whereas this works fine:

public void testLZ4LibFFFlaw() throws Exception {
        byte[] source = new byte[1];
        source[0] = (byte) 0xFF;
        byte[] dest = new byte[1];

        ByteArrayOutputStream bos = new ByteArrayOutputStream();
        LZ4FrameOutputStream compressedStream = new LZ4FrameOutputStream(bos);
        compressedStream.write(source);
        compressedStream.close();

        ByteArrayInputStream bis = new ByteArrayInputStream(bos.toByteArray());
        LZ4FrameInputStream decompressedStream = new LZ4FrameInputStream(bis);
        int i = 0;
        int data;
        while (i == 0) {
            data = decompressedStream.read(dest);
            if (data == -1) {
                break;
            }
        }
        assertEquals(source[0], dest[0]);
    }

[odaira]

Good catch! I'll fix it ASAP.

[odaira]

Fixed by 6081e4ee2dcb1726bb1528a19f34d9e207185059. Thanks!