Clean up interfaces and deprecated methods

lz4 / lz4-java

LZ4 compression for Java

Apache License 2.0

1.1k stars 253 forks source link

Clean up interfaces and deprecated methods #124

Open lJoublanc opened 6 years ago

lJoublanc commented 6 years ago

There are a number of interfaces: LZ4Decompressor, LZ4Compressor, LZ4UnknownSizeDecompressor. These all have abstract compress/decompress methods that are marked deprecated. Could this be cleaned-up? Shouldn't it be possible to just pass around the first two interfaces without caring which implementation we're using?

odaira commented 5 years ago

LZ4Compressor is not an interface and is not deprecated. I think LZ4Decompressor and LZ4UnknownSizeDecompressor can be deleted when lz4-java 2.0 is released some time in the future.

lJoublanc commented 5 years ago

Sorry, you are correct. I should have been specific. I meant LZ4Decompressor, and it's one method decompress.

Deprecated. 
Use LZ4FastDecompressor instead.

@Deprecated
public interface LZ4Decompressor

odaira commented 5 years ago

No problem at all. I'll add it to my TODO list for lz4-java 2.0.