search

lz4 / lz4-java

LZ4 compression for Java
Apache License 2.0
1.1k stars 253 forks source link

Version 1.5.1 breaks Java 9 module system compatibility #137

Closed eikemeier closed 4 years ago

eikemeier commented 5 years ago

Before commit 7d7ca2b8d184c732ccec7a7c5a2b3ef30ead87c8 the automatic module name was lz4.java, which was fine.

Hyphens are not allowed in module (or package) names, so org.lz4.lz4-java isn't valid, therefore not usable as a module.

See also https://github.com/lz4/lz4-java/issues/134#issuecomment-468679621

Workaround: Revert to 1.5.0.

odaira commented 5 years ago

Thanks, I'm working on it at #134. The module name should have been something like org.lz4.lz4_java. Do you have any other suggestion?

eikemeier commented 5 years ago

Actually, I haven't seen underscores in module (or package) names very often.

How about org.lz4.java or simply lz4.java like it is now? You are aiming for org.lz4.lz4.java which will work, but looks strange to me.

odaira commented 5 years ago

Fixed by 01a365726a833adfdace925f246ba08bff4bf32c. Thanks much for your suggestion!

odaira commented 4 years ago

Thanks for your bug report. This was fixed by lz4-java 1.6.0.