LZ4FrameInputStream should read InputStream lazily

lz4 / lz4-java

LZ4 compression for Java

Apache License 2.0

1.1k stars 253 forks source link

LZ4FrameInputStream should read InputStream lazily #146

Closed bjmi closed 4 years ago

bjmi commented 4 years ago

Creating a new LZ4FrameInputStream instance already reads the underlying InputStream by calling nextFrameInfo(). This call should be deferred until an actual read(...) is performed i.e. separate instance creation and utilization.

Advantages

If input is never read or used no resources or handles would be allocated.
My use-case: underlying InputStream is not ready when creating LZ4FrameInputStream but actually is when used.

odaira commented 4 years ago

Fixed by 5e2357339ff4b0dc7eb0e5a21a500d0ca5508594. Instance creation of LZ4FrameInputStream becomes 300x faster. Thanks for your suggestion!