search

lz4 / lz4-java

LZ4 compression for Java
Apache License 2.0
1.11k stars 252 forks source link

JavaSafeCompressor missing in 1.2 and master branch #38

Closed driemekasten closed 9 years ago

driemekasten commented 10 years ago

Lib builds well (except the unsafe-warnings), but the example doesn't run:

Exception in thread "main" java.lang.AssertionError: java.lang.ClassNotFoundException: net.jpountz.lz4.LZ4JavaSafeCompressor

Similar to issue #19.

I'm also interested in building LZ4 with the pure java implementation only.

ecki commented 10 years ago

The java sources are generated with the build/source_template/*.templates. https://github.com/jpountz/lz4-java/blob/master/src/build/source_templates/compressor.template

rit001 commented 10 years ago

One issue I have with this is it means someone can not quickly test lz4 in a pure java environment as they first have to understand its build and configuration system. Could the default java configuration not be one that is a work 100% java configuration.

Thanks

P.S. any notes on how to use the build system would help as it seems to be an extensive system and so not quick to pick up. For now I'm just going to use an older version that does not have all this complexity.

jpountz commented 10 years ago

@ecki is correct.

@rit001 It is true that the build system became more and more complex, mostly in order to avoid duplicating content between the 3 different lz4 and xxhash implementations that we have. This is why I introduced templates that help generate both the safe and unsafe Java impls. I just pushed more information about the build system to the README file (have a look at the end). Please let me know if there is information that you need that is not in this file.

rit001 commented 10 years ago

Thanks, with those notes I found it very easy to build the jars.