search

lzambarda / sn-nord-theme

A Standard Notes theme based on the beautiful nord palette
MIT License
4 stars 1 forks source link

Extension imports, but does not change theme #1

Open ghost opened 3 years ago

ghost commented 3 years ago

The default Standard Notes theme is used when activating this theme; the Nord palette is not used.

lzambarda commented 3 years ago

Hey, not sure on how to resolve this yet. I have been having the same exact issue with other themes.

lzambarda commented 2 years ago

@KyronPeters have you updated to https://github.com/standardnotes/desktop/releases/tag/v3.9.0 ? The way themes are integrated has been reworked, just wanting to check out if it is resolving this issue.

rsesek commented 2 years ago

I believe the issue is the way the CSS is hosted. I see the following in the JS console:

"Cross-Origin Read Blocking (CORB) blocked cross-origin response https://raw.githubusercontent.com/lzambarda/sn-nord-theme/master/theme.css with MIME type text/plain. See https://www.chromestatus.com/feature/5629709824032768 for more details."

lzambarda commented 2 years ago

I believe the issue is the way the CSS is hosted. I see the following in the JS console:

"Cross-Origin Read Blocking (CORB) blocked cross-origin response https://raw.githubusercontent.com/lzambarda/sn-nord-theme/master/theme.css with MIME type text/plain. See https://www.chromestatus.com/feature/5629709824032768 for more details."

This could indeed be the cause. However quite erratic behaviour - may depend on the SN version. Since they completely reworked how themes are imported I will have to spend some time and figure out how to address this. Feel free to have a go and open a PR!