lzanini / mdbook-katex

A preprocessor for mdBook, rendering LaTex equations to HTML at build time.
MIT License
205 stars 34 forks source link

Remove `Cargo.lock` from `.gitignore` #44

Closed jontze closed 1 year ago

jontze commented 1 year ago

First of all, thanks for the good work on this project!

I recently noticed that the repo doesn't include the Cargo.lock file and wondered, if this is on purpose.

To ensure reproducible builds it's recommended to add the Cargo.lock file to version control - beside the project is intended to be used as a lib.

However, I know that some people seem to use this project as a library as well, but the main use case is AFAIK to be used as compiled executable and therefore we would benefit from more reproducible builds due to the lock file.

Refs.:

Feel free to close this PR, if you disagree :smile:

SichangHe commented 1 year ago

For future reference, Cargo.lock has been ignored since #14 when @Matthewacon added a number of katex options.

I cannot see why @Matthewacon did that, and I have no objection to this PR.