lzccccc / SMOKE

SMOKE: Single-Stage Monocular 3D Object Detection via Keypoint Estimation
MIT License
696 stars 177 forks source link

Sigmoid activation on wrong regression features #41

Open tsubu01 opened 3 years ago

tsubu01 commented 3 years ago

Hi Thank you for the fantastic project! Looking at the forward function in SMOKE/blob/master/smoke/modeling/heads/smoke_head/smoke_predictor.py, I was wondering if the sigmoid() function should be applied to features 1 and 2 (the offsets), whereas if I understand correctly, it is currently applied to features 3, 4 and 5 (the dims). Thanks! Tsubu