search

lzeke0 / TwitchRSS

Webapp serving RSS of Twitch broadcasts
Other
123 stars 14 forks source link

Fix for livestreams #33

Closed sn-o-w closed 1 year ago

sn-o-w commented 1 year ago

Looks like now Twitch adds "https://vod-secure.twitch.tv/_404/404_processing_%{width}x%{height}.png" when the livestream is in progress

wyattscarpenter commented 1 year ago

@lzeke0 it sure would save me some trouble if you could find the time to take this pull request!

wyattscarpenter commented 1 year ago

Ah, well, it wasn't that much trouble.

In case anyone else is interested in my workaround: I'm consuming these RSS feeds in a program on my end to process each item. In that program, I now use a regex to detect the string 404_processing in the item, and exclude the item if I find that.

(The string "_404" could conceivably appear in the url if specific parts of a valid thumbnail id(?) is 404, but in the current thumbnail url schema seems to make it impossible that "404_processing" would ever occur unless the thumbnail was the 404.)

lzeke0 commented 1 year ago

I'll take a look, haven't looked at the Twitch API for a while but this was a weird condition to begin with so this might be solving things.

sn-o-w commented 1 year ago

I'll take a look, haven't looked at the Twitch API for a while but this was a weird condition to begin with so this might be solving things.

Yes, it does solve things. I use it for my own instance of TwitchRSS, works perfectly for almost half a year. 👍

lzeke0 commented 1 year ago

Looks good, thank you!