search

lzhan / TwitterWithFragments

0 stars 0 forks source link

[Android Bootcamp] Project4: TwitterWithFragments - Ready for Review #1

Open lzhan opened 9 years ago

lzhan commented 9 years ago

Lichun Zhan's app is complete, please review. /cc @codepathreview @codepath

codepathreview commented 9 years ago

:+1: Project looks good. Good job the way you have architected the fragments by abstracting all common functionality to parent fragment

I have provided a detailed Project 4 Feedback Guide here which covers the most common issues with this submitted project. Read through the feedback guide point-by-point to determine how you might be able to improve your submission.

Let us know if you have any other thoughts or questions about this assignment. Hopefully you can see this coming together as a "fully fledged" twitter client with some more work and polish. This app contains all of the components now (fragments, models, networking, client, tab navigation, image loading, et al) of 90% of dynamic data-driven API client. Obviously there are lots of details and patterns to learn, but by this point you have been introduced to all the major frameworks and concepts. Hopefully you would feel fairly confident getting started making Android apps for instagram, pinterest, yardsale, flickr, using the same patterns.