lzhoang2801 / OpCore-Simplify

A tool designed to simplify the creation of OpenCore EFI
https://lzhoang2801.github.io/gathering-files/opencore-efi
BSD 3-Clause "New" or "Revised" License
411 stars 36 forks source link

[Feature Request] Make it so u can disable unsupported stuff #8

Closed hypermoist closed 1 month ago

hypermoist commented 1 month ago

Since i have a dual gpu system, it would be neat if you can make it so you can disable the unsupported GPUs (ex: RTX 3060) instead of the script out right saying your system is not supported.

lzhoang2801 commented 1 month ago

It seems I have added the patch you needed. Can you try it again and check?

Commit: https://github.com/lzhoang2801/OpCore-Simplify/commit/09e20db00811f9dfabe9bf469656f1df59e0aec5

hypermoist commented 1 month ago

I just ran the .bat and it seems to be pulling sha version e68ab5cc81000a29fff718103cb9f70af493ffe9 which throws Your hardware is not compatible with macOS!

lzhoang2801 commented 1 month ago

Send me your report.json

hypermoist commented 1 month ago

Report.json Here is the attached Report.json

lzhoang2801 commented 1 month ago

Could you re-export the report.json using the latest version of Hardware Sniffer? I have some updates that I need to check before incorporating them into OpCore Simplify

lzhoang2801 commented 1 month ago

The issue will be resolved by rewriting the compatibility check. I will start working on it right now

hypermoist commented 1 month ago

Report.json Adding this just incase you still need it, sorry for late reply.

lzhoang2801 commented 1 month ago

Please use Report.json temporarily to build the EFI and add the bootarg nv_disable=1 to disable your NVIDIA discrete card. With the new version of Hardware Sniffer, I hope it includes the additional information I updated. I don't understand why it doesn't work on your machine

hypermoist commented 1 month ago

Yeah i used the latest 1.2.6 to make my above Report.Json, I'm not to sure why the tool says I'm not compatible, as i know removing the NVidia related args it then reports its compatible

lzhoang2801 commented 1 month ago

Could you open Device Manager, locate your display -> Details -> Location Paths, and provide me with its value?

hypermoist commented 1 month ago

PCIROOT(0)#PCI(0100)#PCI(0000) ACPI(SB)#ACPI(PC00)#ACPI(PEG1)#ACPI(PEGP) - RTX 3060

PCIROOT(0)#PCI(1B00)#PCI(0000) ACPI(SB)#ACPI(PC00)#ACPI(RP21)#ACPI(PXSX) - RX 580

Here you are :)

lzhoang2801 commented 1 month ago

You are providing the location paths of the GPU. I need those for the monitor. Could you please check again?

hypermoist commented 1 month ago

It would seem i do not have a location path under my Monitors Tab in device manager

hypermoist commented 1 month ago

I do have a device instance path? DISPLAY\AOC3402\5&31585CAA&0&UID521

lzhoang2801 commented 1 month ago

That's the exact device I mentioned. However, could you provide the value of the BIOS Device Name or its location paths?

hypermoist commented 1 month ago

Under MonitorName > Details there is no option of Bios Device Name and or Location paths

There is Parent Device stuff Parent Device: PCI\VEN_1002&DEV_67DF&SUBSYS_E3531DA2&REV_E7\4&27741e03&0&00D8

Is this of any use?

lzhoang2801 commented 1 month ago

You've discovered what I was looking for, thank you!

hypermoist commented 1 month ago

How's things going :D

lzhoang2801 commented 1 month ago

I am trying to clean up a few things before updating for your case

hypermoist commented 1 month ago

No problem at all :)

lzhoang2801 commented 1 month ago

Thank you for waiting, please try again with the commit https://github.com/lzhoang2801/OpCore-Simplify/commit/2dff881d6ac0d6075708d19f7bee2163a14624fd

hypermoist commented 1 month ago

Never mind it was my fault ;D

hypermoist commented 1 month ago

Tested it and the checks pass and it reads the json file properly thank you for fixing :D