search

lzhuor / auto_size_text_field

Flutter TextField widget that automatically resizes text field to fit perfectly within its bounds.
https://pub.dev/packages/auto_size_text_field
MIT License
52 stars 35 forks source link

Contents padding and multiline usage #16

Closed hyobbb closed 3 years ago

hyobbb commented 3 years ago

PR of #14

Add contents padding parameter to consider constraints. Merged secondTextSpan comparing when text length is greater than 0. When maxLines = null, fitting method varies.

lzhuor commented 3 years ago

Hi @hyobbb, thank you very much for the PR. Sorry for late reply. I was occupied for some reasons.

Do you mind resolving the merge conflicts?

A few screenshots that demonstrate your fix will also be helpful for the community to know what they are about.

Greatly appreciate your PR. 🚀

hyobbb commented 3 years ago

Hey @lzhuor . I will change some code for null safety and then revise it.

hyobbb commented 3 years ago

@lzhuor Hi. I applied null safety to my code. I changed maxlines property from not-nullable to nullable because it is necessary to be null to implement multi-line textfield without limitation. Also I uploaded mulitline usage example in my repo so please check this out if you need this for readme file.

lzhuor commented 3 years ago

@hyobbb That's so nice of you! Thank you! Will review the code change!

lzhuor commented 3 years ago

Hi @hyobbb Do you mind PR the example and README.md change also in this PR? It will be easier for folks to review as well. Btw, awesome stuff. Excited. 💯

hyobbb commented 3 years ago

Hi @hyobbb Do you mind PR the example and README.md change also in this PR? It will be easier for folks to review as well. Btw, awesome stuff. Excited. 💯

I will do it by this week and let you know!

hyobbb commented 3 years ago

@lzhuor Please check the last commit. I put new gif demo to maxline part.

lzhuor commented 3 years ago

Thanks @hyobbb Checking.

stargazing-dino commented 3 years ago

@hyobbb Should CHANGELOG also be updated? It also looks we should bump the version to 1.0.0+1

Other than that, anything blocking this @lzhuor?

lzhuor commented 3 years ago

Thank you @hyobbb. Merged. Apologies for the delay. I was running some personal errands.

Yes, I will update the CHANGELOG and bump the version.