lzim / teampsd

Team PSD is using GitHub, R and RMarkdown as part of our free and open science workflow.
GNU General Public License v3.0
10 stars 23 forks source link

8/21 task: Team PSD Weekly Tour & Email Pre-approval Policy for Adjusting Tour #1351

Closed lzim closed 4 years ago

lzim commented 4 years ago

@ritahitching - via email on Wed 4/22/2020

Thanks!

FYI: @anthonycpichardo @staceypark

ritahitching commented 4 years ago

@lzim

lzim commented 4 years ago

@ritahitching Discussed at #hqhuddle and this can be trimmed back to reduce redundancy.

Team PSD Weekly Tour (Column A)

Team PSD Leave Requests (Column C)

Add Team PSD Logo

ritahitching commented 4 years ago

@ritahitching add a the TeamPSD Logo

ritahitching commented 4 years ago

@staceypark please review the guide and accept the pull request in issue #1354 when you have time so I can can close this issue and update #1192. thanks

ritahitching commented 4 years ago

@staceypark I updated Draft Team PSD Weekly Tour & Email Pre-approval Policy for Adjusting Tour to reflect your feedback on pull request #1354

Please Clarify To ensure that paths do not break once a pull request is made and approved, please confirm/clarify the best process for uploading documentation that pertains to a branch is to:

  1. Create a branch
  2. Upload files to the branch
  3. Make pull request
  4. Wait for files to be merged to master
  5. Use master repo GitHub links in any working branch where previously uploaded files were needed for documentation (e.g. file 2017_employee_handbook_pavir.pdf needed for Team PSD Weekly Tour & Email Pre-approval Policy for Adjusting Tour).
  6. Only make pull request using master repo GitHub links

@ritahitching

from @staceypark cross ref pull request #1354

  1. Rename and reupload the file "EE 2017 Handbook .pdf". This file name does not follow teampsd convention. It is not machine readable because of the mixed cases and spaces. It is not human readable as "EE 2017 Handbook" is not meaningful to anyone.
  2. Make sure all your bullets are complete sentences, since that's the format you've followed for most of them.
  3. "If approval is granted, changes need to be reflected in ADP with the appropriate code." - This only applies to PAVIR employees as Lindsey outlines in #1351.
  4. Your first three bullet points under "Process to Change Regular Tour" is the same idea rephrased three times. Please combine into one succinct point.
    • [ ] Any scheduled changes to the regular Team PSD tour require written approval in advance. Applies to all types of leave - Vacation, Sick, Jury Duty, Bereavement and Leave of Absence.
    • [ ] No scheduled changes to the tour can be made until approval is granted in writing.
    • [ ] Requests for changes to a regular tour will need to be made formally via email to Dr. Lindsey Zimmerman (i.e. a text message is not sufficient).
  5. The images and hyperlinks are all linked within your own branch right now. If you remember from our training, these paths do not update in your pull request and will break. The path always needs to be written to the master branch.
staceypark commented 4 years ago

@ritahitching Thanks for outlining your understanding and proposal of how this would work! 🎉

You can do this in one of two ways. I would go with whatever is easiest for you.

  1. You can follow what you outlined, which is to separate the pull request for 1) file upload and 2) file editing

or...

  1. You can do the 1) file upload and 2) file editing in one go. Notice the two sections I bolded & italicized in the links below.

Please Clarify To ensure that paths do not break once a pull request is made and approved, please confirm/clarify the best process for uploading documentation that pertains to a branch is to:

  1. Create a branch
  2. Upload files to the branch
  3. Make pull request
  4. Wait for files to be merged to master
  5. Use master repo GitHub links in any working branch where previously uploaded files were needed for documentation (e.g. file 2017_employee_handbook_pavir.pdf needed for Team PSD Weekly Tour & Email Pre-approval Policy for Adjusting Tour).
  6. Only make pull request using master repo GitHub links

Next Steps

ritahitching commented 4 years ago

@staceypark Thank you for the guidance on file naming and merging to master - very helpful. Please accept the new pull request made #1393.

ritahitching commented 4 years ago

@ritahitching Moved issue to May Epic.

staceypark commented 4 years ago

@anthonycpichardo merged all these changes last week. This documentation will need updating with our new flex/compress changes and schedule, which we can create a new card for as we get things solidified.

this particular task I believe can be closed. @lzim @lijenn