lzim / teampsd

Team PSD is using GitHub, R and RMarkdown as part of our free and open science workflow.
GNU General Public License v3.0
15 stars 23 forks source link

Facility File Testing #1667

Closed anthonycpichardo closed 3 years ago

anthonycpichardo commented 3 years ago

Say Guides: (Red): https://github.com/lzim/mtl/blob/feature-directory_scan/red/part1/part1_facilitator/mtl_red_part_1_say.md

(Blue): https://github.com/lzim/mtl/blob/feature-directory_scan/blue/session02/s02_facilitator/mtl_session02_say.md

See Guides: (Red): https://github.com/lzim/mtl/blob/feature-directory_scan/red/part1/part1_learner/mtl_red_part_1_see.md

(Blue): https://github.com/lzim/mtl/blob/feature-directory_scan/blue/session02/s02_learner/mtl_session02_see.md

facility.xlsb file :

detail_facilitate: (for MTL Manual - Facilitator section).

lzim commented 3 years ago

@anazariz and @anthonycpichardo

Did @jamesmrollins and @dkngenda receive their facility testing files earlier today okay? I haven't seen updates for each step on here (yet).

We need sign-offs on each step of QA, likely in the future these should each be separate cards with assignees, dependencies and estimates.

anthonycpichardo commented 3 years ago

I agree @lzim that in the future we would have a card for each test step.

Ash and I are wrapping up dev testing now and will have the test files ready shortly for folks to be able to test in the morning.

The data query took more time to run than scoped.

FYI: To ensure we have the data ready for our sites we will be running the propagation for the wave 1 sites prior to propagating all of the facilities-- once testing is complete

anazariz commented 3 years ago

@anazariz Test Results: vizDiag chart did not size correctly on workbook load - fixed.

anthonycpichardo commented 3 years ago

Testing results -

lijenn commented 3 years ago

@anthonycpichardo @anazariz I'm still in the process of testing the facility file, I can't recall the decision but did we want the Control tab to be unhidden on default?

@dkngenda @jamesmrollins the documentation has been updated to include the Control tab documentation. Please see updated links to the SEE/SAY guide in Anthony's intial comment on this card as the guides are in a feature branch in the lzim/mtl repo and not in the master branch yet.

Please go ahead and start testing the facility file now, thank you!

anthonycpichardo commented 3 years ago

Good question @lijenn, I think it makes sense for it to be hidden as users won't need to use it in 99% of cases. The 1% being if for some reason they want to refresh the data?

dkngenda commented 3 years ago

@anthonycpichardo @anazariz graphs are appearing on top of some tables, is that okay? - looks like they can be moved around

anthonycpichardo commented 3 years ago

Yes they are intentionally on top of the tables

anazariz commented 3 years ago

@anthony, re your feeback, "need to remove the pivotChart Fields settings from being open on launch", yes, I will remove them prior to propagation.

anazariz commented 3 years ago

@lzim @staceypark @lijenn @dkngenda @jamesmrollins folks, when done, please move your tested (or untested) files to either completed\ or did not complete\. That way @anthonycpichardo and I will know the testing that still remains if we are to propagate the file(s) today. Thanks.

dkngenda commented 3 years ago

Testing results

lijenn commented 3 years ago

@anazariz @anthonycpichardo Testing results:

Some issues I did see, but unable to recreate:

anthonycpichardo commented 3 years ago

Interesting that both of the errors seem to be inconsistent

dkngenda commented 3 years ago

I got this message when going through the facilitate.xlb image

anthonycpichardo commented 3 years ago

Was this the file that Ash pointed you to in the test folder? The workbook being mentioned in the alert is not the same as the test file.

Select no if you still have the dialog open.

dkngenda commented 3 years ago

My bad! I was just going through the facilitate manual clicking around to follow the instructions

anthonycpichardo commented 3 years ago

ah I see. You got this error when navigating to 605? I will test this as well.

Verified that 605_facility.xlsb is opening successfully without errors.

staceypark commented 3 years ago

@anthonycpichardo @anazariz

facility.xlsb file :

The above items were all fine. An additional point though, that isn't a bug, so much as a usability issue. Some of the filters have "Select Multiple Items" pre-selected and shows the checkboxes which you can click and unclick. Some do not. I think consistency across the filters on how they work is key for reducing confusion.

Between the two options, I would lean towards showing the checkboxes with the pre-selected "select multiple items". Less confusing on how to use the filters to me.

from VizDiag division name image

from VizEnc location name image

anthonycpichardo commented 3 years ago

Good feedback. I think we would need to explore how to do that.

dkngenda commented 3 years ago

@lijenn @staceypark Say (Red) guide

anthonycpichardo commented 3 years ago

@lzim We have received feedback from all users stating the requirements outlined on the testing checklist above have been met.

Recommending that we begin the propagation for the wave 1 sites.

staceypark commented 3 years ago

Ok we will take a look

@lijenn @staceypark Say (Red) guide

  • Section 2 bullet 2 is not entirely clear to me. Are we referring to the folder on the splash page?
  • There is a reference to these tabs " countDiag, countEnc, countHF, and countMeas;" but I din't see them in the facility file.
staceypark commented 3 years ago

Is it as simple as pre-clicking those checkboxes for "select multiple items" pre-propagation?

Good feedback. I think we would need to explore how to do that.

anthonycpichardo commented 3 years ago

Is it as simple as pre-clicking those checkboxes for "select multiple items" pre-propagation?

Good feedback. I think we would need to explore how to do that.

I can test that, but I'm not sure how that would play with the reset button.

If its that simple that would be great.

anthonycpichardo commented 3 years ago

Is it as simple as pre-clicking those checkboxes for "select multiple items" pre-propagation?

Good feedback. I think we would need to explore how to do that.

I can test that, but I'm not sure how that would play with the reset button.

If its that simple that would be great.

That seems to have worked, I'll implement that.

jamesmrollins commented 3 years ago

@lijenn with regard to the Red and Blue Say guides, I have the following comments. I did not have enough time to resolve issues with Excel, run very slow queries and check all the guides. However, the key ask above, " Documentation for unhiding the Control Tab and Refreshing the data is clear and easy to follow" has not been achieved. Since the guides all seem derivative, we likely can assume the changes would need to be made across all of them.

I also have a few more comments as well. These may be hard to follow, but I am willing to review them in person with you.

mtl_red_part_1_say.md

  1. bullet 3 states: "A web version of Excel will open on your screen, showing your facility's data in charts."

What actually happened: A directory in BISL is displayed which indicates a 663_facility.xlsb file is displayed.

  1. bullet 2 states: "If you do not see a team folder, request a team folder above."

Observation: It is not clear what "folder above" means. On first entry into the system, there wouldn't be a team folder, or is someone else creating it? Is it created when the team goes through co-planning?

  1. Time Stamp - Team Learning Priorities - Script for Session 2, table needs to be fixed.

  2. "If the data is not loading or showing incorrect facilities/clinics, here's how to refresh" refresh procedure is not consistent with actual dialogue in spreadsheet.

  1. We have been working in the beginning of the Say guide in the splashpage. Then we transition back to BISL and then to the Data UI file. Consider a more solid transition.
  1. Regarding #4. Go to the ClinicSelection tab. Use columns C-H . . .

Note: Consider color coding the buttons in cells B3 through B6. It took me a few minutes to find the "add all" button. Also consider capitalizing the names of the buttons in the instructions in cell A2. Also, consider left-justifying the cell and bulletizing the instructions in A2, it will be easier to read.

mtl_session02_say.md

  1. Under #2, bullet 2, says, "Team files are in team folders. If you do not see a team folder, request a team folder above." Where is above?

  2. Under #2, is says, "There are two types of View options at the bottom of the spreadsheet. __ (Team Lead's name) Will you please click through them, so we can see what each displays?" What view options? Do we mean to say, "There are two views available in each worksheet, a graph and a table." Or, "There are data view options available in the tabs at the bottom of the spreadsheet."

  3. Under heading "All data is sortable and filterable so that the team can transparently see how the charting you do all day becomes VA data."

  1. Under "If the data is not loading or showing . . ." this needs to be corrected.

  2. Under heading, "To create a fresh data UI file, go through Steps #3-5."

  1. Time Stamp - Team Learning Priorities - Script for Session 2, table needs to be fixed.

I also recommend we go through a lint process together after I delete the heading punctuation rule. It may speed up our editing process if I can share my lessons learned with you.

staceypark commented 3 years ago

@anthonycpichardo @lzim confirmed propagation for wave 1. She will be checking Fresno at 5:30am

@lzim We have received feedback from all users stating the requirements outlined on the testing checklist above have been met.

Recommending that we begin the propagation for the wave 1 sites.

anthonycpichardo commented 3 years ago

Great will be running it now and verifying that every thing is peachy keen

lzim commented 3 years ago

@anthonycpichardo @anazariz

I will not have time for any other testing other than my preparations for tomorrow.

Even if we don't have separate cards, I still do want us to sign off on the QA roles for each step (from my post yesterday):

We need sign-offs on each step of QA, likely in the future these should each be separate cards with assignees, dependencies > and estimates.

DEV QA - Anthony & Ash (sign-off) TEST QA - Stacey Documentation (sign-off) TEST QA - James and David walk through guides and facility.xlsxb file (sign-off).

anthonycpichardo commented 3 years ago

Thanks for the update, the latest facility file should be available for 570 @lzim

anthonycpichardo commented 3 years ago

Facility File Feedback to be implemented:

anthonycpichardo commented 3 years ago

Documentation being tracked under #1678