Closed anthonycpichardo closed 3 years ago
@anazariz and @anthonycpichardo
Did @jamesmrollins and @dkngenda receive their facility testing files earlier today okay? I haven't seen updates for each step on here (yet).
We need sign-offs on each step of QA, likely in the future these should each be separate cards with assignees, dependencies and estimates.
I agree @lzim that in the future we would have a card for each test step.
Ash and I are wrapping up dev testing now and will have the test files ready shortly for folks to be able to test in the morning.
The data query took more time to run than scoped.
FYI: To ensure we have the data ready for our sites we will be running the propagation for the wave 1 sites prior to propagating all of the facilities-- once testing is complete
@anazariz Test Results: vizDiag chart did not size correctly on workbook load - fixed.
Testing results -
@anthonycpichardo @anazariz I'm still in the process of testing the facility file, I can't recall the decision but did we want the Control tab to be unhidden on default?
@dkngenda @jamesmrollins the documentation has been updated to include the Control tab documentation. Please see updated links to the SEE/SAY guide in Anthony's intial comment on this card as the guides are in a feature branch in the lzim/mtl repo and not in the master branch yet.
Please go ahead and start testing the facility file now, thank you!
Good question @lijenn, I think it makes sense for it to be hidden as users won't need to use it in 99% of cases. The 1% being if for some reason they want to refresh the data?
@anthonycpichardo @anazariz graphs are appearing on top of some tables, is that okay? - looks like they can be moved around
Yes they are intentionally on top of the tables
@anthony, re your feeback, "need to remove the pivotChart Fields settings from being open on launch", yes, I will remove them prior to propagation.
@lzim @staceypark @lijenn @dkngenda @jamesmrollins
folks, when done, please move your tested (or untested) files to either completed\
Testing results
@anazariz @anthonycpichardo Testing results:
Some issues I did see, but unable to recreate:
Same issue that Stacey previously mentioned where the lines in the graph extend into the legend, here its in VizDiag tab and appeared when I randomly filtered through the Division Name. (FYI I tried to recreate this a 2nd time but it seems to be fine now? Was unable to recreate after I clicked 'Reset Pivot Chart' and worked fine afterwards).
When all filters are selected and filtered (divisionname, locationname, and VVC - selected to VVC) in VizEnc tab, nothing appears in the graph. But when VVC is selected to non-VVC, the graph appears. Also tried to recreate this but now it seems to be fine?
Interesting that both of the errors seem to be inconsistent
I got this message when going through the facilitate.xlb
Was this the file that Ash pointed you to in the test folder? The workbook being mentioned in the alert is not the same as the test file.
Select no if you still have the dialog open.
My bad! I was just going through the facilitate manual clicking around to follow the instructions
ah I see. You got this error when navigating to 605? I will test this as well.
Verified that 605_facility.xlsb is opening successfully without errors.
@anthonycpichardo @anazariz
facility.xlsb file :
The above items were all fine. An additional point though, that isn't a bug, so much as a usability issue. Some of the filters have "Select Multiple Items" pre-selected and shows the checkboxes which you can click and unclick. Some do not. I think consistency across the filters on how they work is key for reducing confusion.
Between the two options, I would lean towards showing the checkboxes with the pre-selected "select multiple items". Less confusing on how to use the filters to me.
from VizDiag division name
from VizEnc location name
Good feedback. I think we would need to explore how to do that.
@lijenn @staceypark Say (Red) guide
@lzim We have received feedback from all users stating the requirements outlined on the testing checklist above have been met.
Recommending that we begin the propagation for the wave 1 sites.
Ok we will take a look
@lijenn @staceypark Say (Red) guide
- Section 2 bullet 2 is not entirely clear to me. Are we referring to the folder on the splash page?
- There is a reference to these tabs " countDiag, countEnc, countHF, and countMeas;" but I din't see them in the facility file.
Is it as simple as pre-clicking those checkboxes for "select multiple items" pre-propagation?
Good feedback. I think we would need to explore how to do that.
Is it as simple as pre-clicking those checkboxes for "select multiple items" pre-propagation?
Good feedback. I think we would need to explore how to do that.
I can test that, but I'm not sure how that would play with the reset button.
If its that simple that would be great.
Is it as simple as pre-clicking those checkboxes for "select multiple items" pre-propagation?
Good feedback. I think we would need to explore how to do that.
I can test that, but I'm not sure how that would play with the reset button.
If its that simple that would be great.
That seems to have worked, I'll implement that.
@lijenn with regard to the Red and Blue Say guides, I have the following comments. I did not have enough time to resolve issues with Excel, run very slow queries and check all the guides. However, the key ask above, " Documentation for unhiding the Control Tab and Refreshing the data is clear and easy to follow" has not been achieved. Since the guides all seem derivative, we likely can assume the changes would need to be made across all of them.
I also have a few more comments as well. These may be hard to follow, but I am willing to review them in person with you.
What actually happened: A directory in BISL is displayed which indicates a 663_facility.xlsb file is displayed.
Observation: It is not clear what "folder above" means. On first entry into the system, there wouldn't be a team folder, or is someone else creating it? Is it created when the team goes through co-planning?
Time Stamp - Team Learning Priorities - Script for Session 2, table needs to be fixed.
"If the data is not loading or showing incorrect facilities/clinics, here's how to refresh" refresh procedure is not consistent with actual dialogue in spreadsheet.
The second bullet indicates a "control" selection will be in the "Unhide" menu. The only two selections presented in the spreadsheet were "drop down" and "Hidden."
I think the problem is the first bullet instruction says, "To refresh your facility file's data, right click on any tab at the bottom of the Excel spreadsheet and select **Unhide..." I think the user must actually navigate to the "Control" worksheet tab, select a facility in cell C2 on the top of the worksheet and click the "Refresh" button on the top of the page. Revealing the hidden tab is a function of the Propogate button according to the instructions on the worksheet.
Third bullet says, "Note that this will pull all clinics used in the last two years (including de-activated clinics: denoted by "ZZ"). You can see the de-activated clinics in column I." Consider, "Note that this will pull all clinics used in the last two years, including de-activated clinics (denoted by a "ZZ" prefix). You can also see the de-activated clinic's inactivation date in column I."
Forth bullet says, "Follow the instructions in Box A2." Consider, "Follow the instructions in cell A2." Or - draw a box around the cell and keep the "box" language. The word "cell" is used in the two bullets that follow bullet 4
Note: Consider color coding the buttons in cells B3 through B6. It took me a few minutes to find the "add all" button. Also consider capitalizing the names of the buttons in the instructions in cell A2. Also, consider left-justifying the cell and bulletizing the instructions in A2, it will be easier to read.
Under #2, bullet 2, says, "Team files are in team folders. If you do not see a team folder, request a team folder above." Where is above?
Under #2, is says, "There are two types of View options at the bottom of the spreadsheet. __ (Team Lead's name) Will you please click through them, so we can see what each displays?" What view options? Do we mean to say, "There are two views available in each worksheet, a graph and a table." Or, "There are data view options available in the tabs at the bottom of the spreadsheet."
Under heading "All data is sortable and filterable so that the team can transparently see how the charting you do all day becomes VA data."
Regarding # 2, "For each "viz" chart, you can filter on location and clinic name (upper left) to zoom in to the clinic or VISTA clinic/"grid". (During intersession prep facilitator should fill-in the rankings of the highest priority viz that should be emphasized during the team meeting. Follow the team's lead "live" during the meeting, but be prepared.)."
The options on the chart are "divisioname" and "locationname" and are inconsistent with " . . . location and clinic name (upper left) . . ."
Under "If the data is not loading or showing . . ." this needs to be corrected.
Under heading, "To create a fresh data UI file, go through Steps #3-5."
Regarding #4. Go to the ClinicSelection tab. Use columns C-H . . .
Third bullet says, "Note that this will pull all clinics used in the last two years (including de-activated clinics: denoted by "ZZ"). You can see the de-activated clinics in column I." Consider, "Note that this will pull all clinics used in the last two years, including de-activated clinics (denoted by a "ZZ" prefix). You can also see the de-activated clinic's inactivation date in column I."
Forth bullet says, "Follow the instructions in Box A2." Consider, "Follow the instructions in cell A2." Or - draw a box around the cell and keep the "box" language. The word "cell" is used in the two bullets that follow bullet 4
I also recommend we go through a lint process together after I delete the heading punctuation rule. It may speed up our editing process if I can share my lessons learned with you.
@anthonycpichardo @lzim confirmed propagation for wave 1. She will be checking Fresno at 5:30am
@lzim We have received feedback from all users stating the requirements outlined on the testing checklist above have been met.
Recommending that we begin the propagation for the wave 1 sites.
Great will be running it now and verifying that every thing is peachy keen
@anthonycpichardo @anazariz
I will not have time for any other testing other than my preparations for tomorrow.
Even if we don't have separate cards, I still do want us to sign off on the QA roles for each step (from my post yesterday):
We need sign-offs on each step of QA, likely in the future these should each be separate cards with assignees, dependencies > and estimates.
DEV QA - Anthony & Ash (sign-off) TEST QA - Stacey Documentation (sign-off) TEST QA - James and David walk through guides and facility.xlsxb file (sign-off).
Thanks for the update, the latest facility file should be available for 570 @lzim
Facility File Feedback to be implemented:
Documentation being tracked under #1678
Say Guides: (Red): https://github.com/lzim/mtl/blob/feature-directory_scan/red/part1/part1_facilitator/mtl_red_part_1_say.md
(Blue): https://github.com/lzim/mtl/blob/feature-directory_scan/blue/session02/s02_facilitator/mtl_session02_say.md
See Guides: (Red): https://github.com/lzim/mtl/blob/feature-directory_scan/red/part1/part1_learner/mtl_red_part_1_see.md
(Blue): https://github.com/lzim/mtl/blob/feature-directory_scan/blue/session02/s02_learner/mtl_session02_see.md
facility.xlsb file :
detail_facilitate: (for MTL Manual - Facilitator section).