search

lzim / teampsd

Team PSD is using GitHub, R and RMarkdown as part of our free and open science workflow.
GNU General Public License v3.0
9 stars 23 forks source link

Data UI Testing #1668

Closed anthonycpichardo closed 3 years ago

anthonycpichardo commented 3 years ago

Say Guides: (Red): https://github.com/lzim/mtl/blob/master/red/part1/part1_facilitator/mtl_red_part_1_say.md (Red): https://github.com/lzim/mtl/blob/master/red/part2/part2_facilitator/mtl_red_part_2_say.md (Blue): https://github.com/lzim/mtl/blob/master/blue/session02/s02_facilitator/mtl_session02_say.md (Blue): https://github.com/lzim/mtl/blob/master/blue/session03/s03_facilitator/mtl_session03_say.md

See Guides: (Red): https://github.com/lzim/mtl/blob/master/red/part1/part1_learner/mtl_red_part_1_see.md (Red): https://github.com/lzim/mtl/blob/master/red/part2/part2_learner/mtl_red_part_2_see.md (Blue): https://github.com/lzim/mtl/blob/master/blue/session02/s02_learner/mtl_session02_see.md (Blue): https://github.com/lzim/mtl/blob/master/blue/session03/s03_learner/mtl_session03_see.md

data_ui file :

data_ui cheatsheet

anthonycpichardo commented 3 years ago

For the LSV messaging how does the following sound?

image

This is an update to the confirmation message that existed previously which stated:

These queries may take a while, and Excel will be unresponsive until they complete. Proceed?

Appreciate the feedback.

@lzim @lijenn @staceypark @anazariz

anthonycpichardo commented 3 years ago

@jamesmrollins @dkngenda @lijenn @staceypark

The data ui file is ready to be tested for the criteria outlined above.

Test files have been created for each tester in the quant_wg folder > final_datafiles > test

Once testing is completed please move your file into the completed folder.

To view the LSV alert remember that you will need to have clinics selected as instructed in the file. You will not need to run the query as the dialog box allows you to cancel.

jamesmrollins commented 3 years ago

@anazariz @anthonycpichardo

  1. The test instruction did not work as explained in the text shown below:

"VVC & Fiscal year filters are working and correctly drill down the data on the vizenc tab

  1. I did run the LSV queries, and the warning dialogues appeared to work correctly. However, the query was not able to run for what I suspect were connectivity issues.
staceypark commented 3 years ago

@anthonycpichardo @anazariz data_ui file :

anthonycpichardo commented 3 years ago

@anthonycpichardo @anazariz data_ui file :

  • [x] divisionname filter is visible on vizEnc, vizDiag, vizHF and vizMeas - in vizMeas, the divisionname filter comes after rowtype. In all of our other viz, divisionname is always first on the top left. please change it to make it match
  • [x] There are no unusable buttons on the graphs - in multiple filters and viz there's a "blank" instead of the filter option or month. Can we get rid of this? Is this a bug?

  • [x] VVC & Fiscal year filters are working and correctly drill down the data on the vizenc tab

    • To switch to fiscal year view you will right click the table behind the graph and select "switch to fiscal date" from the drop down. To revert back to the calendar year press the "reset pivot chart" button - This is VERY confusing. We have not previously in any guide, cheatsheet, video, etc. interacted with the Excel in this way. It is always through the filters on the table. What is the rationale for this method of implementation? Can it not be a filter or button the graph?"
  • [x] The "Hidden" tab of the data_ui is not visible
  • [x] LSV Run time alert pops up when you click the "Get Patient Data" or "Get Team Data Table" buttons - Right now it says "Excel will be unresponsive." Just to double check the entire Excel app for any other file will be unresponsive right? I think it should clarify that even more somehow. Perhaps "These queries may take a while, and the Excel app will be unresponsive until they complete. You will not not be able to open any other Excel file during that time."

Thanks for the feedback Stacey!

For the Fiscal Year implementation #1619, I agree that it is not ideal from a usability perspective but the need is because it can't be a filter or a button on the graph. The way the data cube is built wouldnt allow for a simple filter option to change between the fiscal & calendar year.

It could potentially be a button similar to the reset pivot chart if that is something we'd like pursue.

lzim commented 3 years ago

I agree with @staceypark's usability concerns here:

VVC & Fiscal year filters are working and correctly drill down the data on the vizenc tab To switch to fiscal year view you will right click the table behind the graph and select "switch to fiscal date" from the drop down. To revert back to the calendar year press the "reset pivot chart" button

I've asked @anthonycpichardo to propagate Fresno Data UI, I will try to work on their data as my test.

@anthonycpichardo Can we clarify in the LSV query message something that helps them to interpret the message? Also, I don't think any clinicians will know what LSV means, so strip that.

I propose the following message:

"Custom data queries for large VAs can take awhile. VA limits query run times to 5 minutes between 6AM & 12noon Eastern. The limit is 15 minutes from 12noon to midnight Eastern. Excel will be unresponsive until queries complete. Proceed now?"

dkngenda commented 3 years ago

Test results

data_ui file :

data_ui cheatsheet

dkngenda commented 3 years ago

@anthonycpichardo the folder structure shown in the screenshots used in the guides is not the same as the structure I see on the splash page. Is this folder structure dependent on the facility or is supposed to be standardized across facilities?

lzim commented 3 years ago

FYI @anazariz @anthonycpichardo

image

I got this, this morning.

Update at 9:26AM: image

So, I clicked "OK" to refresh.

Then, I tried pulling the "PCT" clinics using "Clinic Selection" And, I received this error message:

image

I clicked "debug" and I see this:

image

I also see this on the "vizMeas" tab:

image

lijenn commented 3 years ago

@dkngenda Thanks for the feedback on the creating the team folders, think @jamesmrollins documented similar feedback as well from the facility issue card. @staceypark and I will work on getting the updated folder instructions in the data cheatsheet and the instructions in see/say guides, will create a new issue card for these updates.

We also documented issues with the current process/workflow for creating team folders at #1674

@ anthonycpichardo the folder structure shown in the screenshots used in the guides is not the same as the structure I see on the splash page. Is this folder structure dependent on the facility or is supposed to be standardized across facilities?

David and I clarified that the folder structure shown in the gifs were outdated as we have since cleaned up and hid the old folders shown in the gif. I will work on updating the gif.

lzim commented 3 years ago

@anazariz @anthonycpichardo

Ongoing issues working with Data UI 1. Time out error received after 12noon Eastern image

2. Where I was in the process: image

anthonycpichardo commented 3 years ago

I will be addressing the following feedback from this issue:

Ash will address:

lzim commented 3 years ago

@anthonycpichardo Will you please confirm you received my message on 2/2 - I don't see it captured anywhere Thanks!

anthonycpichardo commented 3 years ago

Confirmed.

anazariz commented 3 years ago

@lzim @staceypark @lijenn @anthonycpichardo

I corrected multiple issues Data UI and propagated 666 and 589.

Issues Fixed:

1-an "out of range" error would come up with the viz sheets due to indexing inconsistency. I fixed it. 2-in vizMeas "sum of patients" was had replaced "distinct count of patients causing errors - I fixed it 3-a refresh on an empty table was throwing an error-I fixed it. 4-a click on the reset button on an empty pivot table was throwing error - I fixed it

anthonycpichardo commented 3 years ago

Documentation being tracked under #1678

lzim commented 3 years ago

@anthonycpichardo and @anazariz

What fixes should my 589 Data UI files have? I see a list on the quant_workgroup thread on VA Teams.

I was asking because I was hoping that this message would show up for any wave 1 NIH teams. The reason is because no clinicians will be familiar with what LSV means, hence my re-writes.

Thanks!

anthonycpichardo commented 3 years ago

This change is available for propagation.

Will you be impacted if I propagate the change now?