lzim / teampsd

Team PSD is using GitHub, R and RMarkdown as part of our free and open science workflow.
GNU General Public License v3.0
15 stars 23 forks source link

wk4_aug_QA_test: SIM UI Features - Multiple Issues July Epic Release #2121

Closed jamesmrollins closed 3 years ago

jamesmrollins commented 3 years ago

QA Check Instructions

Conditions

  1. Given a team set up that includes _ind and _team sharing the same root with a saved experiment with simulation reset, from a _team session. (#2106)
  2. Given a team set up excel spreadsheet from CRM. (#1968) (#2104)
  3. Given an AGG session that requires Balanced Mode discussion and comparison. (#2107)
  4. Given a sim session that requires discussion around a chart that has percentages as a unit of measure. (#2117)
  5. Given an experiment that is saved in a _team group (#2105)

Please Verify

Condition 1 (reference issue #2106)

Condition 2 (reference #1968 and #2104)

Condition 3 (reference #2107)

Condition 4 (reference #2117)

Condition 5 (reference #2105)

~- [ ] An experiment that has been saved and the sim reset, is available in all _ind, _team and _shared groups that share the same team root name.~ @lijenn is adding new qa tests since we've updated this feature to be only 1 directional to prevent confusion among Learners and Facilitators seeing a ton of experiments and the ability to identify which experiments are Team experiments versus their own world experiments.

lijenn commented 3 years ago

Hi @jamesmrollins, 2 questions:

  1. For Condition 1 - #2106 I can't seem to get this feature to work in my test team world "jenn_shared_world_test" with how we currently name our team data table files (i.e. it worked when I had a test team data table file named "jenn_shared_world_test.xlsx", but not the below).

    • Does the feature account for the bolded part here in a team data table file's name?
    • jenn_shared_worldtestall_without_SP_2021_04_26.xlsx
  2. For Condition 2 - Specifically #1968 Is there a button or visual indicator from the Dashboard/Team Setup/Add/Drag-n-drop dialogue to drag-n-drop an excel sheet for the team setup? Not seeing anything new here: image

jamesmrollins commented 3 years ago

Hi @lijenn. This QA Test isn't scheduled until next week, so many of the features you are testing are not available yet.

lijenn commented 3 years ago

Feedback and Qs for Condition 2 (reference #1968 and #2010)

1. Can we rename or change the language for the drag-n-drop for Team Set up? Worried Team Data might be referred to as the Team Data Table file since they sound similar. What about something like this so it matches the blue header's name:

2. Can we add an indicator to let the user know that their file was added in the drag-n-drop? Currently, when I drag my exported file to the area, it does not tell me that I have successfully put a file there. At the least, I'd at least like to see the name of the file that I uploaded, something like this: image

3. Possible Future Release - Any way we can upload more than 1 Team Setup file to set up more than 1+ team at 1 go? Could look something similar to this pic: image

4. Unable to "Edit" or view the team created from the export unless I click "Add" another team first.

5. Not all members from the exported file are added.

Only you seem to show up? Could it be related to the console error from 4., might have something to do with Stacey and me and the worlds assigned to us in Test? image

jenn_crm_export_test.xlsx

jamesmrollins commented 3 years ago

Hi @hirenp-waferwire . Please take a look at the feedback above from the UAT. This is reference to issue #1968 and #2110. @lijenn makes a good observation and improvement suggestions:

I like the multi-file upload idea as well, but I will create an issue card to track that separately. We have to conserve hours between now and the end of the fiscal year.

More feedback to follow tomorrow.

jamesmrollins commented 3 years ago

Hi @lijenn We fixed the bugs above, but were not able to recreate the problem with team creation you reported. When we used your file, it worked fine. Can you run through it again and see if you run into any trouble? Thanks - James

lijenn commented 3 years ago

Thank you @jamesmrollins! Unfortunately I'm still experiencing a variety of bugs with the export and had some questions for Condition 1 & 5.

I have checked everything else that looks good besides these that need fixes or a discussion:

Condition 3 (reference #2107)

Cannot open the (i) and (BC) pop-ups simultaneously for Learning Mode header in CC & MM: image image


For reference, this is the team root for the feedback below: 123_jenn_issue2121_attempt2

Condition 1 (reference #2106)

I'm not sure if the qa check boxes reflect this feature? I might be mistaken since I thought #2106 is purely related to the team data table file showing up in all _team, _ind, and the _shared worlds. But the test cases all refer to experiments.

If the qa checks are referring to the team data file, I am still experiencing the same bug I got with Lindsey's and Nearhoof's ind worlds documented here, where deleting a file from individual world, deletes from all of the other member's individual worlds.

And vice versa, uploading the team data table file in 1 individual world will add to all the other member's individual worlds. See condition 5 below as adding the team data table file was also a part of that process.

Condition 5 (reference #2105)

Having some trouble this one, below were the steps I took to test this:

  1. I first set up 2 experiments in the _team world after adding in the Team Data Table file.
  2. I did not see the Team Data Table file get auto-added into the _shared or _ind worlds.
  3. I add the team data table file to Debra's _ind world.
  4. I start a new session in the _ind world and do not see the 2 experiments in the blue Experiment dropdown header.
  5. I run and then save and reset an experiment in the _ind world, then I see the 2 experiments from the _team world + the exp. I just ran: image
  6. I check the other _ind worlds and they now all have the team data table file auto-uploaded and all 3 experiments in the Experiments drop down and the Experiment Maintenance section.
  7. I delete the team data table file from one of the _ind worlds, this deletes the team data table file for all the other _ind worlds too.
  8. No effects on _shared world. Team data table is not automatically added. Tried recreating step 3-5 for shared world and the experiments from the _team world and _ind world still do not show up: image

Let's touch base tomorrow please!

jamesmrollins commented 3 years ago

Findings from Joint User Acceptance Testing with @lijenn 8/6

@hirenp-waferwire

image

image

image

image

image

jamesmrollins commented 3 years ago

Comment from WG Leads meeting 8/9.

Regarding the cached state of a user session

  1. Will the small changes in the AGG model somehow disrupt a current, un-reset user session?
  2. Is there a way to set up a test environment that will validate whether the update will mess up a user session?
jamesmrollins commented 3 years ago

@lzim @staceypark @lijenn

Results from Meeting with DEV Regarding Saved Experiments and Cached Sessions

  1. Any change to a variable name invalidates previous experiments (but we have workaround - see below). The name is the critical element of the variable as all code mapping is dependent on that name. If a variable name is changed in any way, it will corrupt the mapping.
  2. We don't have the ability to import experiments from one server to another.
  3. However, as a general rule there would be no testing required if we follow rule number one.
  4. Any post run, non-reset sessions will need to be saved and reset before we migrate TEST to PROD. This way, when the session is loaded, it uses the new model fresh.

Workaround

  1. To be able to use experiments that our study participants have already saved and want to use, we are going to hard code the ability for the AGG model to read both the legacy and new variable names in the experiment data file. The user should not have an issue reading legacy experiments.
  2. This can always be a workaround, but its complexity is directly proportional to the number of variables changed.

Lessons Learned

  1. @jamesmrollins needs to do offer more resistance to changing variable names! This has happened multiple times and I really need to stop letting this happen - I am embarrassed 😣
  2. We should better coordinate release with PREP and TEAM meeting schedules (as we discussed earlier).
  3. Our planning should assume a save and reset of all active sessions prior to a release. This will be a good use of our News and Andon Alert systems.
  4. The above does not apply to BreakFix.
jamesmrollins commented 3 years ago

Regarding number 1 below

Comment from WG Leads meeting 8/9.

Regarding the cached state of a user session

  1. Will the small changes in the AGG model somehow disrupt a current, un-reset user session?
  2. Is there a way to set up a test environment that will validate whether the update will mess up a user session?

Regarding AGG Experiments Saved Prior to Release to PROD

lijenn commented 3 years ago

@jamesmrollins

Condition 2 - #1968

Drag-n-drop Sim UI Dynamics Export working great except it's adding me as a Facilitator into the Team World and Ind World, even though I'm not in the dynamics export.

Could it be because I'm the person creating the team so it's trying to automatically add myself to all the worlds? Sent you the dynamics export on non-VA Teams. image

API Multiplayer Bug for Team World?

After adding the team data table file from the Dashboard and assigning the data file to the 3 group/worlds, I tried going into the Team World but got this API World bug. I do not get this bug for the Shared or Ind worlds. image

jamesmrollins commented 3 years ago

Hi @lijenn , the first observation is working as designed, the person setting up the team is automatically a facilitator. The second one is a bug, we'll look into it. Thanks for the quality check !

jamesmrollins commented 3 years ago

Hi @hirenp-waferwire , see big report above. Thanks James

lijenn commented 3 years ago

@jamesmrollins @hirenp-waferwire Because of the Team World API multiplayer bug, I don't think the #2106 feature implemented a day ago is working (at least in the old Team Worlds) to see if the experiments being created in the Team World are shared to the Individual and Shared Worlds, but I will test that feature again once the Multiplayer API bug is fixed.

Thank you both!!!

lijenn commented 3 years ago

Working great @hirenp-waferwire & @jamesmrollins :) !!!

Only thing I'd suggest is renaming the blue header here:

Header name: Select Worlds

Then below in the white space, what about adding instructions like this: Please select the worlds the Team Data file should load into. @lzim @staceypark You guys might have better suggestions on this.

image

Other than that, I'm giving the green light for this gigantic release on Sunday. Thank you both!!

@lijenn @staceypark Will need to look at what could be the smallest guide updates for Experiments and Team Data Table file features on Monday 8am WG leads.

jamesmrollins commented 3 years ago

Hi @lijenn - Thank you for the thorough review. I will make the change you suggest above: @hirenp-waferwire - Please see changes below.

Popup Title: "Please select a world" Popup Explanation: " Check the boxes to load the team data file into the desired worlds."

lijenn commented 3 years ago

Done and in Prod, thanks!