wk3 apr_epic #story_l Bug: deprecation errors, teampsd repo

lzim / teampsd

Team PSD is using GitHub, R and RMarkdown as part of our free and open science workflow.

GNU General Public License v3.0

15 stars 23 forks source link

wk3 apr_epic #story_l Bug: deprecation errors, teampsd repo #3037

Closed ljmoody closed 7 months ago

ljmoody commented 12 months ago

Receiving deprecation errors upon render-book actions firing fyi @tejaspesquare

Discovered 11/20/2023 when merging a feature-gh-pages branch to gh-pages wtihin teampsd repo.
Error message: see highlighted portions of screenshot below.

lijenn commented 9 months ago

@ljmoody Where are we with this bug? Can you please update the ZenHub details or bring this the 2024_feb_roadmap? Thanks!

ljmoody commented 9 months ago

@lijenn, the MTL repo was prioritized (with the same two bugs), so the render-book issue and Node 12 deprecation error (https://github.com/lzim/teampsd/issues/3037) for TeamPSD repo haven't been addressed as of yet.

@tejaspesquare - is there an update or estimate for when https://github.com/lzim/teampsd/issues/3036 and https://github.com/lzim/teampsd/issues/3037 may be addressed by your team?

ljmoody commented 9 months ago

@tejaspesquare - FYI: I updated a feature branch and submitted a pull request today. Below is a screenshot of the action checker deprecation errors: Node.js 16, node12, set-output.

ljmoody commented 9 months ago

Hi @tejaspesquare, today I merged the above pull request into the main gh-pages branch and received the deprecation error shown below; I'll add the render-book errors to that separate card (#3036). It was unsuccessful.

Additionally, I looked back several months, and it looks like the following pull requests were not successful and did not update information as they should have: #3007, #3035, #3077.

Error message:

r-lib/actions/setup-r@v1 is deprecated. r-lib/actions/setup-r@v1 is deprecated. Please update your workflow to use the 'v2' version. Also look at the examples at https://github.com/r-lib/actions/tree/v2/examples because '@v2' workflows are much simpler than 'v1' workflows.

fyi @lijenn

tejaspesquare commented 9 months ago

@ljmoody - We have applied changes for following 2 branches (v2 replaced with v3, actions/checkout@v3). Can you please check it should work.

ljmoody commented 9 months ago

Hi @tejaspesquare - the v1 deprecation error is now solved. 🎉 This deprecation error still remains, but I'm unsure of if it's technically a deprecation error or a render-book error, so am including a screenshot here, as well as in #3036:

fyi @lijenn

lijenn commented 7 months ago

Discussed Team Praxis Meeting: @jamesmrollins resolved deprecation bugs.