lzim / teampsd

Team PSD is using GitHub, R and RMarkdown as part of our free and open science workflow.
GNU General Public License v3.0
9 stars 23 forks source link

wk3 2024_mar_epic #story_l: deprecation errors, mtl repo #3038

Closed ljmoody closed 6 months ago

ljmoody commented 10 months ago

Receiving deprecation errors in mtl repo when render-book actions fire in mtl repo FYI @tejaspesquare, Jenn and I would like to use the gh-pages rendering of the MTL manual in our training session with users on November 29. If there is something I need to do or can do to help, please let me know.

Discovered 11/20/2023 when merging a feature-gh-pages branch to gh-pages branch within mtl repo. Error messages: see highlighted portions of screenshot below.

image

tejaspesquare commented 10 months ago

@ljmoody We are not sure for what reason it is occurring. It will require thorough investigation on the issue & will take time.

At moment we are focusing on tasks mentioned here https://github.com/lzim/teampsd/issues/3029 (see at bottom 24th Nov comments)

Looping in colleague @lijenn since we're working on this together.

lijenn commented 9 months ago

@tejaspesquare In case this helps, I wonder if our renderbook.yml needs to be updated with the new version?

I found this from the README.md of the owner/github action's repo: https://github.com/JamesIves/github-pages-deploy-action#using-an-ssh-deploy-key-

tejaspesquare commented 9 months ago

@ljmoody @lijenn We have found one solution but not certain it will work or not. Could you please apply change on renderbook.yml by adding following variable & see if it works.

env: ACTIONS_ALLOW_UNSECURE_COMMANDS: 'true'

image

We can setup a call to do trial run. Please let us know your suitable time in case it is required.

lijenn commented 8 months ago

@tejaspesquare We tried adding the code below in the .yml file, but it didn't work. Any updates on the deprecation errors?

env: ACTIONS_ALLOW_UNSECURE_COMMANDS: 'true'

tejaspesquare commented 8 months ago

@lijenn - We will update you soon about this error. Actually, we are waiting for meeting with James to verify solution we found. Thanks!

jamesmrollins commented 8 months ago

@tejaspesquare you can coordinate directly with @ljmoody and @lijenn for issues regarding actions and testing.

jamesmrollins commented 8 months ago

WaferWire reviewed this problem and determine that we needed to update our version of setup-r@v1 to setup-r@v2 on line 19 of the renderbook.yml action. We are going to test by merging completed branches.

ljmoody commented 8 months ago

@tejaspesquare - Adding a new (to me) deprecation Action Checker message to this thread. Discovered 1/29/24 when committing changes to a .md file in the MTL repo:

image

FYI @lijenn @jamesmrollins

lijenn commented 7 months ago

@tejaspesquare Any updates on Laura's bug above? Thanks!

lijenn commented 6 months ago

Discussed Team Praxis Meeting: @jamesmrollins resolved deprecation bugs.