lzim / teampsd

Team PSD is using GitHub, R and RMarkdown as part of our free and open science workflow.
GNU General Public License v3.0
9 stars 23 forks source link

Need wk3 #2024_apr_epic MTL 3.7 Release: Sim UI TEST Bug - Reorder Name field & Email Field Team Setup in Sim UI TEST #3060

Closed ljmoody closed 6 months ago

ljmoody commented 8 months ago

1. "Name" field should display first and last name, not email.

image

  1. Discovered January 24, 2024, morning, while testing with Jenn Li - within TEST environment.

**2. In order for Team PSD to track this issue you must assign

lijenn commented 6 months ago

Dev team will work to address/troubleshoot this issue this week.

tejaspesquare commented 6 months ago

@ljmoody , @lijenn - Could you please check while configured a member in a team having First Name as email Id or actual name.

image

in case actual Name

ljmoody commented 6 months ago

@tejaspesquare, I am responding here, but am sending you 2 testing videos via Praxis team chat because the videos show information we do not want to share publicly. Please review the videos and respond here with any suggestions, questions, or further testing ideas and requests. Thank you.

tejaspesquare commented 6 months ago

@ljmoody - We have gone through videos attached on Praxis team chat; we will be working into it. Thanks!

tejaspesquare commented 6 months ago

@ljmoody - This is handled & moved to TEST-Slow. Kindly check from your end.

image

ljmoody commented 6 months ago

@tejaspesquare, this is still not functioning properly from my testing in TEST-Slow this morning. Please see videos on Praxis team chat for testing examples which indicate:

tejaspesquare commented 6 months ago

@ljmoody - Now adding members should work.

From My testing on TEST-Slow

Adding members-

image

The newly created team is saved; however, I cannot see the newly created team in the Facility Team Setup team list. -> We shall track this in #3061

ljmoody commented 6 months ago

Hi @tejaspesquare, Jenn and I tested adding new users to a team and that is functioning. 👍

We need to change the way auto-added user(s) information is displayed to complete this task. Please ensure:

This screenshot shows how the auto-added users are displaying now: image

jamesmrollins commented 6 months ago

3/17 Sim UI Standup

See Forio's explanation below:

image

tejaspesquare commented 6 months ago

@jamesmrollins , @ljmoody , @lijenn - We have fixed this & available on SIM Dev environment. Once you are ok with result will promote code to TEST-Slow. image

ljmoody commented 6 months ago

@tejaspesquare I tested in DEV instance today and emails are populating the correct columns. As an additional FYI, the auto-added users were not included in these team setups. Is this expected behavior in DEV instance--or not? image image image

ljmoody commented 6 months ago

Hi @tejaspesquare - is it possible to promote this to TEST-Slow? (And please respond to my question in italics above. I know it's a different issue, but want to be clear on the expected behavior in both DEV and TEST-Slow instances so I know for validation and testing purposes.)

tejaspesquare commented 6 months ago

@ljmoody - Code is promoted to TEST-Slow. On Dev instance there are only 2 users default added while team setup performing- i. devuser7 & ii. devusershared. I missed to respond yesterday itself. I'm so sorry.

ljmoody commented 6 months ago

Thanks for your clarification, @tejaspesquare! It's informative.

I validated in TEST-Slow today that: ✅ name column is populating correctly with both first and last names ✅ emails are only showing in the email column ✅ BONUS: that all 6 auto-added people are being added to the teams as well! 🕺

Screenshots of _ind, _team, and _shared world teams after initial setup: image

image

image

Closing this issue as completed. fyi: @jamesmrollins @lijenn