lzim / teampsd

Team PSD is using GitHub, R and RMarkdown as part of our free and open science workflow.
GNU General Public License v3.0
9 stars 23 forks source link

2024_10 DEV Team Flow and Team Care Flows #3085

Open lijenn opened 9 months ago

lijenn commented 9 months ago

Copied from #3024

All DEV Cards for Flow:

3049 - CC and MM Flow - closed

3086 - Psy

3085 - Team Care and Team Flow


Team Care Flow Diagram Wireframe

image

image

image

image

Acceptance Criteria

jamesmrollins commented 4 months ago

@lzim

Note: The MVP means that the flow diagrams work as designed but may not support scaling or dynamic window sizing. This will take considerable effort and may require several more weeks to accomplish. I also need to verify that scaling is possible (it should be because are using SVG).

jamesmrollins commented 4 months ago

@lzim @ljmoody @lijenn

Sim UI Workflow 7/3

jamesmrollins commented 3 months ago

@tejaspesquare Please provide a weekending update for this effort. Thank you.

tejaspesquare commented 3 months ago

Hi @jamesmrollins,

Development for Team Care Flow meter is currently in progress. The flow diagram has been completed, and work is underway to build the logic for rendering data by developer. Hoping, it should be ready by Monday EOD.

just FYI - This development is a collaborative effort between the Designer and Developer. Designer is also engaged in other internal assignments hence not able to join all the time for this project.

image image

Note: Flow Diagram for Team Flow designing part is under way from Designer.

matthewtomo commented 3 months ago

Discussed DEV Standup 7/29/2024 @matthewtomo @tejaspesquare

fyi: @jamesmrollins @lijenn @ljmoody

matthewtomo commented 3 months ago

Discussed in DEV Standup 8/1/2024 @matthewtomo @tejaspesquare

fyi: @jamesmrollins @lijenn @ljmoody

tejaspesquare commented 3 months ago

Hello @ljmoody , @lijenn , @matomasz

  • Design work is currently in progress for Team Flow Diagram.

The design phase for Team Flow has been finished. Developer will proceed to next stage of development once Team Care is completed.

FYI: @jamesmrollins

matthewtomo commented 3 months ago

Discussed SDM-DOC CI/CD meeting 8/6/2024 @matthewtomo @jamesmrollins

tejaspesquare commented 3 months ago

Hi @matomasz ,

  • @tejaspesquare can you confirm which variable names are not being captured in your API calls?

Missing Variables- Flow Meter Development for Team Care (Agg)_Updated 7thAug.txt

Attached updated list of variables associated with Agg (Team Care) model. Some of variables present in API response which were not found earlier.

Example: For CC -> CC Evaluation Rate is not found in API call image

tejaspesquare commented 3 months ago

Hi @matomasz

Attached is a list of missing variables that are associated with Team flow. MIssing Variables-Flow Meter Development for Team Flow(SP).txt

Note: We are not sure how this match will be working (SIM UI) GMH Recommend Step up Rate -> (API Response) PC/PCMHI to GMH Recommend Step up Rate

matthewtomo commented 2 months ago

Discussed DEV standup 8/9/2024 @matthewtomo @tejaspesquare

ljmoody commented 2 months ago

@matthewtomo, placing these suggested graphical improvements for flow here (originally from a comment in #3168). This-and other suggestions-may require continued design development and discussions between sim_ui & Lindsey.


Graphical improvements

image


Discussed DEV standup 8/9/2024 @matthewtomo @tejaspesquare

Graphical improvements

  • [ ] 1. The flows "bend" to/from the flows, creating unnecessary visual complexity AND challenges when zooming in to read the small text values. Recommend that there are no turns in the flows, just parallel left to right viewing to/from the stocks.

image

matthewtomo commented 2 months ago

Discussed DEV standup 8/9/2024 @matthewtomo @tejaspesquare

@tejaspesquare the model files are now up to date for the sim UI in Forio Epicenter DEV

matthewtomo commented 2 months ago

Discussed DEV Standup 8/12/24 @matthewtomo @tejaspesquare

fyi: @jamesmrollins

Error Message:

{
  "trace": [
    {
      "type": "python",
      "function": "load_model",
      "file": "/usr/local/lib/python3.10/dist-packages/epicenter/worker/vensim/vensim_worker.py",
      "line": 58
    },
    {
      "type": "python",
      "function": "load_model",
      "file": "/usr/local/lib/python3.10/dist-packages/epicenter/worker/vensim/vensim_wrapper.py",
      "line": 32
    },
    {
      "type": "python",
      "function": "vensim_command",
      "file": "/usr/local/lib/python3.10/dist-packages/epicenter/worker/vensim/vensim_wrapper.py",
      "line": 176
    }
  ],
  "information": {
    "runKey": "0000019146a0e46b62a2c400189e0065fd20",
    "code": "MODEL_INITIATION"
  },
  "type": "python",
  "message": "VensimLibraryException: Vensim command(SPECIAL\u003ELOADMODEL|/home/epicenter/model/0000019146a0e46b62a2c400189e0065fd20/agg_PROD.vmfx) failed)"
tejaspesquare commented 2 months ago

Hi @matomasz

Attached is a list of missing variables that are associated with Team flow. MIssing Variables-Flow Meter Development for Team Flow(SP).txt

Note: We are not sure how this match will be working (SIM UI) GMH Recommend Step up Rate -> (API Response) PC/PCMHI to GMH Recommend Step up Rate

Do we have any updated on this?

matthewtomo commented 2 months ago

Discussed Dev Standup8/14/2024 @matthewtomo @tejaspesquare

fyi: @lzim @lijenn @ljmoody

matthewtomo commented 2 months ago

Discussed Dev Standup8/14/2024 @matthewtomo @tejaspesquare

matthewtomo commented 2 months ago

Discussed 8/15/2024 @matthewtomo @jamesmrollins

matthewtomo commented 2 months ago

Discussed #DEV_Standup @matthewtomo @tejaspesquare

matthewtomo commented 2 months ago

wk3 2024_08 Dev Standup @matthewtomo @tejaspesquare

matthewtomo commented 2 months ago

Discussed Dev Standup wk4 2024_08 @matthewtomo @tejaspesquare

tejaspesquare commented 2 months ago

Hello @jamesmrollins , @matomasz

Team Care (Agg) development is completed & can be verified on Dev instance. Fig #1 image

Fig #2 image

Note: Fig #2 - We have noticed under patients -> Patients in Service appointments figure is overlapped with blue bar box.

FYI - @ljmoody , @lijenn

matthewtomo commented 2 months ago

@tejaspesquare

tejaspesquare commented 2 months ago

Hi Matthew

  • It does not look like the bars connecting stocks and flows are properly proportioned.
  • The large blue areas are bars with widths of over 20000 px in the css styling tab.

The issue that was identified yesterday has been resolved. Could you kindly verify again using multiple model files for MM & Team Care (Agg), if feasible?

  1. Team Care(Agg)
    • The Booking Rate and Completing Rate reflect the actual flow value, with the Dialmax value maintained at 100 in a code; otherwise, it would have been set to 50 for both dials. image
  1. MM Appointments image

    Patients image

Thank You!

matthewtomo commented 2 months ago

@tejaspesquare, here is my update for the SP variables. I have a few I need to check with James about and a few that I was able to provide you names for: Corrected.Variables-Flow.Meter.Development.for.Team.Flow.SP.txt

Everything after this is notes/explanation for what I did to track these down. No need to read all of it, but it might help make better sense of the issues I need to address with James.

It was a little confusing to figure out which variables you were referring to. The three categories exist in a ranked order:

For example, you can step up from PC/PCMHI to GMH, from PC/PCMHI to SMH, or from GMH to SMH. These are all steps up because they go up this ranking. There is no step up from SMH as there are no higher rankings. Following the logic in the opposite direction, you can step down from SMH to GMH, from SMH to PC/PCMHI, or from GMH to PC/PCMHI. There is no step down from PC/PCMHI as there are no lower rankings.

I will copy over a few photos from the wireframes (page 9) and discuss what I was able to find.

Team Flow (TF) and Measurement Based Stepped Care (MBSC) Flow Diagrams:

image image

Team Flow (TF) and Measurement Based Stepped Care (MBSC) Flow Keys:

image image

How I tried to locate the variables you are missing

Using these as a reference I will use "TF" when referring to Team Flow and "MBSC" when referring to Measurement Based Stepped Care.

First I tried to Identify each variable you asked for on the diagrams, then I used its identifiers (TF or MBSC) (Associated Letter or Number) to find it in the key, then I checked to make sure it was available in the model File.

Results

GMH

GMH Step up Rate

GMH Recommend Step up Rate

GMH Recommend New Episode of Care Start Rate

GMH Recommend Step down Rate

GMH Recommend Step up Rate (This is a duplicate of the second in this section, but that is how it appeared in your list)

GMH Patients Waiting for Step up Rate

GMH Step Down Rate

SMH

SMH High Risk Flag Patient Stepped Care Rate

SMH Step up Rate

SMH Recommend Step up Rate

SMH Recommend New Episode of Care Start Rate

SMH Recommend Step down Rate

SMH Patients Waiting for Step up Rate

SMH Step Down Rate

PC/PCMHI

PC/PCMHI High Risk Flag Patient Stepped Care Rate

PC/PCMHI Step up Rate

PC/PCMHI Recommend Step up Rate

PC/PCMHI Recommend New Episode of Care Start Rate

PC/PCMHI Recommend Step down Rate

PC/PCMHI Patients Waiting for Step up Rate

PC/PCMHI Step Down Rate

matthewtomo commented 2 months ago

@tejaspesquare

matthewtomo commented 2 months ago

Discussed Dev Standup wk_1 2024_9 @matthewtomo @tejaspesquare

fyi: @jamesmrollins @ljmoody

matthewtomo commented 2 months ago

Discussed Dev Standup wk_1 2024_9 @matthewtomo @tejaspesquare

matthewtomo commented 1 month ago

Discussed Dev Standup wk_2 2024_9 @matthewtomo @tejaspesquare

matthewtomo commented 1 month ago

Discussed Friday Dev Standup wk_2 2024_9 @matthewtomo @tejaspesquare

matthewtomo commented 1 month ago

Discussed Dev Standup wk_3 2024_9 @matthewtomo @tejaspesquare

matthewtomo commented 1 month ago

Discussed Friday Dev Standup wk_3 2024_09 @matthewtomo @tejaspesquare

fyi: @jamesmrollins @ljmoody

matthewtomo commented 1 month ago

Discussed Friday Dev Standup wk_4 2024_09 @matthewtomo @tejaspesquare

lzim commented 1 month ago

@matthewtomo @jamesmrollins

Can we try to avoid holding up Team Care just because Team Flow is having fails?