2024_apr_epic: Sim UI PROD MM Learning Mode Save Dialogue names Learning Mode 0 and Learning Mode 1 as NPSR

lzim commented 3 months ago

AC:

[ ] Labels needed to indicate Learning Mode (NPSR = 1; EPRVI = 0):
- [ ] Home landing page instruction for how to initiate a new session in a different learning mode - James
- [x] Home Screen in Learning Mode dialogue itself need (0,1) label in the Learning Mode (NPSR = 1; EPRVI = 0)
- [ ] Experiments Section "i" (see Lindsey's comment below) - James
- [x] Experiments Section "bc" (see Lindsey's comment below) - Dev
- [x] Results Dashboard in the "?" for each experiment (see Lindsey's comment below) - Dev
- [x] Save Dialogue should indicate all the information (0,1) - Dev

As you can see in the check below.

Two Base Case Experiments were run one in Learning Mode 1 and one in Learning Mode 0, but both are saved as NPSR.

[ ] Where do frontend Sim UI users check the alignment between? Learning Mode 1 and Learning Mode 0 New Patient Start Rate (NPSR) mode and Existing Return-Visit-Interval (ERVI) mode

lzim commented 3 months ago

Label Needed: Learning Mode (NPSR = 1; EPRVI = 0)

- [ ] Home landing page instruction for how to initiate a new session in a different learning mode

Current State: Can do this with reselecting data to start a new session.

- [ ] Home Screen in Learning Mode Dialogue Itself Need (0,1) Label in the Learning Mode (NPSR = X; ERVI = X)

- [ ] Experiments Section "i" and "bc"

- [ ] Results Dashboard in the "?" for each experiment

[ ] Save Dialogue should indicate all the information (0,1) and

jamesmrollins commented 3 months ago

3/20 Standup

@jamesmrollins was not able to force the error with the system.
@tejaspesquare and Divyesh will fix the experiment maintenance issue so the files will list.
@lijenn will delete test experiment and correctly rename the NPSR to EPRVI in the morning.
@jamesmrollins will detail instructions to DEV for changes to model and popups to incorporate explanations of the learning modes as specified above.

tejaspesquare commented 3 months ago

@jamesmrollins - Prod - now files are listed on Experiment Maintenance section.

It was restricted to render earlier just because some items having undefined name present, being handled now.

lijenn commented 3 months ago

@lijenn Deleted the Q8_EPRVI_bc_2024_3_20 experiment and renamed Q8_NPSR_bc_2024_3_20 to Q8_EPRVI_bc_2024_3_20 since the Learning Mode coded in the experiment was 0 and not 1.

ljmoody commented 3 months ago

@tejaspesquare Jenn and I tested in TEST-Slow, Care Coordination module. Experiments using learning mode 0 are not being named correctly.

tejaspesquare commented 3 months ago

@ljmoody , @lijenn - Could you please check now on TEST-Slow . Experiments using learning mode o showing correct value & named correctly

lijenn commented 3 months ago

@tejaspesquare Thanks for fixing this is TEST-SLOW. @ljmoody and I will test today.

This problem was also observed in PROD too. Can you evaluate and push this code fix as necessary, into Prod?

jamesmrollins commented 3 months ago

@tejaspesquare -

[x] Please add the following changes to ALL Learning Mode dialogue pop-ups in Test and PROD.

[ ] Please confirm whether our GitHub CICD routine has been restored for model update. Note that we should have a CICD action that where updated model files will be moved to the respective projects, by merging a model file into a DEV branch, then merging DEV into TEST and then merging TEST into Master in LZIM/MTL.
[ ] @jamesmrollins will then update the model "i" information as indicated above and merge new model files as indicated above.

tejaspesquare commented 3 months ago

@jamesmrollins - We have applied changes in in Learning mode pop-ups in Test & Prod.

Prod-

Queries:

Could you please tell us shall we apply this change on Test Break-fix or not.
Do we need to change this code to 'ESRVI' from RVI (pink highlighted)

Note: On Test-Slow instance this is in-progress. Design related changes is pending.

lijenn commented 3 months ago

Hi @lzim and @dlounsbu! Are you both running experiments in the Prod for team lzim/research #595? If so, please ignore the soft moss data file:

@tejaspesquare Did you add this file for this team in Prod? If not, this is a bug.

ljmoody commented 3 months ago

Hello @tejaspesquare.

In PROD:

[x] Please make these edits to the Learning Mode popup:
[ ] Yes, please push this to Break-fix as well.

In TEST:

[x] Jenn and I do not see the updated Learning Mode popup. We see this:

tejaspesquare commented 3 months ago

@lijenn - Yes, we were using soft moss model file for troubleshoot the issue which James reported reg. API response data. @ljmoody - Learning Mode changes will be updated in PROD & Break-fix. On Test-Slow it is not available yet, code change done but some design changes need to apply.

tejaspesquare commented 3 months ago

@ljmoody & @lijenn - Please find updates below:

Prod Instance-

Test Slow-

lijenn commented 3 months ago

@lijenn - Yes, we were using soft moss model file for troubleshoot the issue which James reported reg. API response data. @ljmoody - Learning Mode changes will be updated in PROD & Break-fix. On Test-Slow it is not available yet, code change done but some design changes need to apply.

Thanks @tejaspesquare! Would it be alright for us to delete the soft moss data file in Prod?

ljmoody commented 3 months ago

Hi @tejaspesquare, please revise accordingly:

In break-fix:

in Test-slow:

ljmoody commented 2 months ago

Discussed at stand up 3/31/2024. @tejaspesquare will mirror Break Fix and Test Slow to have the same wording and formatting as Prod.

tejaspesquare commented 2 months ago

@ljmoody - Changes applied on Test-Slow. Break-Fix not updated yet as that will auto apply once code migration happen.

lzim commented 2 months ago

Thanks @tejaspesquare & @ljmoody

lzim commented 2 months ago

Whoops...didn't mean to close it tho...it's early here. 🌞

ljmoody commented 2 months ago

@tejaspesquare, I noticed a misspelling in Test-Slow:

[x] Please correct spelling in Experiment > Rename popup:

tejaspesquare commented 2 months ago

@ljmoody - Rename Experiment popup title spell is corrected & available in Test-Slow.

ljmoody commented 2 months ago

Tested Learning Mode saved experiments for both modes in Test-Slow using:

29march_laura_shared world
Team Data file: sampledata_2024_03_29.xlsx
CC experiment entered as EPRVI labeled and categorized correctly:
MM experiment entered as NPSR is labeled and categorized correctly:

@tejaspesquare, I believe this validates the fix and it can be pushed to PROD instance now. fyi: @lijenn

ljmoody commented 2 months ago

✅ Validated spelling correction was made.

@ljmoody - Rename Experiment popup title spell is corrected & available in Test-Slow.

ljmoody commented 2 months ago

@tejaspesquare - I looked at the Learning Mode pop-ups in Test-Slow, PROD, and Break-Fix today.

[x] Revisions are needed in PROD (see below)
[x] Same revisions are needed in Break-Fix, and I understand from your message above on 4/1 that will auto-apply once code migration happens

lijenn commented 2 months ago

Discussed Sim UI Stand Up 04/03/2024:

~@tejaspesquare will be able to make the revisions in Break Fix once the migration from Prod to Break Fix is completed. Will reach out to us next week for updates.~ See 4/7 updates below.

lijenn commented 2 months ago

Discussed 4/7 Sim UI Stand up:

@tejaspesquare will start with the migration from TEST-SLOW to BREAK-FIX (will be a copy of PROD). Will fix the issue in Prod for CC module.
@ljmoody and @lijenn can test Prod CC once it's ready.

tejaspesquare commented 2 months ago

@lijenn - Revision for Learning mode is done on both Prod & Break-fix. Kindly check at your end.

Test Break-fix:

Prod:

ljmoody commented 2 months ago

4/14 standup:

@ljmoody will test this week.

ljmoody commented 2 months ago

fyi: @tejaspesquare @lijenn @jamesmrollins Tested in PROD instance and verified: ✅ Learning mode popup text is correct in PROD and Break-Fix. ✅ CC experiments are saved correctly with EPRVI and NPSR acronyms and learning mode codes (0, 1) ✅ MM experiments are saved correctly with EPRVI and NPSR acronyms and learning mode codes - screenshots below:

ljmoody commented 2 months ago

@jamesmrollins, please incorporate the following modifications and check off as/when completed so Jenn and I can validate.

[ ] 1. Home landing page instruction for how to initiate a new session in a different learning mode. Per AC above.
[ ] 2. Changes to Experiments Section "i":

ljmoody commented 2 months ago

@tejaspesquare, please incorporate the following changes and check off as/when complete so Jenn and I can validate.

[x] 1. Changes to Experiments Section "bc":
[x] 2. Changes to Results Dashboard in the "?" for each experiment:
[x] 3. Changes to Experiment Slider Abbreviations blue bar in Save Experiment pop-up (Save Dialogue should indicate all the information (0,1)):

jamesmrollins commented 2 months ago

4/21 Sim UI

Completed in DEV environment up for local testing.
Will be available tomorrow 4/22 for end user testing.

ljmoody commented 2 months ago

Tested 4/22 in test-slow. ✅ Verified changes to Experiments Section "bc": @tejaspesquare, there are two modifications needed in this Learning Mode pop-up:

[x] Please align the highlighted text to the left (versus justified).
[x] Looks like boldface was lost when the text update was made. Please see Point 1 above in my comment last week and re-apply boldface to the requested text.

✅ Verified changes to Results Dashboard in the "?" for each experiment:

✅ Verified changes to Experiment Slider Abbreviations blue bar in Save Experiment pop-up:

tejaspesquare commented 2 months ago

@ljmoody - Text alignment & boldface is done. Kindly verify on Test Slow. Thank You!

ljmoody commented 2 months ago

Hi @tejaspesquare, I can verify that the bolding is correct. The alignment still looks the same (what I see is the same as what you've pictured, and it looks the same as before). If this is a quick fix and easy to do, please try again. Should look similar to this:

@ljmoody - Text alignment & boldface is done. Kindly verify on Test Slow. Thank You!

tejaspesquare commented 2 months ago

@ljmoody - Left alignment is done & available on Test-slow.

Note: Bold result is slightly differed because background color effect (of EPRVI & NPSR).

lijenn commented 2 months ago

Discussed Stand Up 04/24/24:

@lijenn will test the above and then close the card if there are no issues.

lijenn commented 2 months ago

Jenn verified the left alignment is completed in CC and MM. Moving to Done column, @ljmoody feel free to close if the documentation is done for this.

ljmoody commented 1 month ago

Hi @lijenn, There are still two items James has yet to complete from Lindsey's checklist above, I think:

[ ] Home landing page instruction for how to initiate a new session in a different learning mode
- Or is the above considered "done" by the red learning mode buttons and documentation in the MTL manual?
[ ] Experiments Section "i" (needs to indicate learning mode #s)

Re: documentation, I've added "include info re: places indicating Learning Modes (NPSR = 1; EPRVI = 0) (ref #3131)" as a checklist item in #3030.

ljmoody commented 1 month ago

@lzim, to clarify re: labels needed and your note about "Home landing page instruction for how to initiate a new session in a different learning mode", do you want this information to be added to the end of the intro text at the top (highlighted in the graphic below)? fyi: The Learning Mode pop-up does show up in two places of this page (see numbered pins) and the learning modes are specified there:

lzim / teampsd